Add 'nilness' to golangci #14066
Add 'nilness' to golangci #14066
Conversation
nilness reports:
# github.com/cilium/cilium/pkg/k8s/version
pkg/k8s/version/version.go:278:9: impossible condition: nil != nil
Fix it by reusing the outer err variable.
CC: Deepesh Pathak <deepshpathak@gmail.com>
Fixes: fb101df ("k8s: add coordinationv1 capability check to k8s version package")
Signed-off-by: Joe Stringer <joe@cilium.io>
nilness complains that the local secret error is hidden:
pkg/crypto/certificatemanager/certificate_manager.go:81:33:
impossible condition: nil != nil
Fix it by unhiding the outer ioErr variable.
CC: Jarno Rajahalme <jarno@covalent.io>
Fixes: cabf83c ("crypto: Add local GetSecrets().")
Signed-off-by: Joe Stringer <joe@cilium.io>
Suggested-by: Tam Mach <sayboras@yahoo.com> Signed-off-by: Joe Stringer <joe@cilium.io>
joestringer
force-pushed
the
submit/nilness
branch
from
371e310
to
a406d1f
Compare
|
@christarazi actually it's part of my old git "fixes" formatting scripts: https://github.com/joestringer/config/blob/1c050f3807e03cb8ba283c90b05416767f493576/.gitconfig#L8 |
joestringer
requested review from
fristonio and
jrajahalme
and removed request for
jibi and
brb
|
Reassigned since it's probably more important to get the original authors to take a look both since they'll know that code and as a way to point out this pattern of bug to reduce recurrance of such issues. |
joestringer
changed the title
|
test-me-please |
joestringer
added
the
ready-to-merge
|
GKE only issue, but seems unlikely that it's any way connected to the changes in this PR: https://jenkins.cilium.io/job/Cilium-PR-K8s-GKE/3342/execution/node/115/log/ |
|
No need to backport to 1.9, all future patches should go through master and therefore have these checks applied at the time of submission. |
|
I also received out-of-band confirmation from @jrajahalme that these patches do not need backport to v1.9 as the outer code already handles such error conditions. |
Nilness checks for common programming errors like nil pointer dereference or degenerate nil pointer comparisons. It can find bugs, add it to the golangci target.
https://pkg.go.dev/golang.org/x/tools/go/analysis/passes/nilness
Add it to the CI, and fix up the couple of legitimate failures it complains about in the codebase.
Technically the two identified errors are bugs, but they do not appear to be at all severe so I see no strong motivation to backport this PR to v1.9.