-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
helm: Add extraConfig in configmap template #14077
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michi-covalent
added
release-note/minor
This PR changes functionality that users may find relevant to operating Cilium.
needs-backport/1.9
labels
Nov 18, 2020
sayboras
approved these changes
Nov 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 to have similar feature as per 1.8
rolinh
approved these changes
Nov 19, 2020
kaworu
approved these changes
Nov 19, 2020
test-me-please |
sayboras
added
the
dont-merge/needs-rebase
This PR needs to be rebased because it has merge conflicts.
label
Nov 21, 2020
aanm
approved these changes
Nov 23, 2020
errordeveloper
approved these changes
Nov 25, 2020
This allows users to provide additional fields in the configmap without having them explicitly listed in the template. For example, you can do: % cat my-config.yaml extraConfig: my-config-a: "1234" my-config-b: |- test 1 test 2 test 3 % helm install ./cilium -n kube-system -f ./my-config.yaml to add my-config-a and my-config-b to cilium-config. This could be useful in case the template is missing some fields. Ref: #13317 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
force-pushed
the
pr/michi/extraconfig
branch
from
December 3, 2020 03:25
8945c32
to
de44341
Compare
gandro
added
the
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
label
Dec 3, 2020
Added the |
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.9
in 1.9.1
Dec 4, 2020
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.9
in 1.9.1
Dec 4, 2020
maintainer-s-little-helper
bot
moved this from Backport pending to v1.9
to Backport done to v1.9
in 1.9.1
Dec 4, 2020
maintainer-s-little-helper
bot
moved this from Backport pending to v1.9
to Backport done to v1.9
in 1.9.1
Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/helm
Impacts helm charts and user deployment experience
dont-merge/needs-rebase
This PR needs to be rebased because it has merge conflicts.
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/minor
This PR changes functionality that users may find relevant to operating Cilium.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to provide additional fields in the configmap without
having them explicitly listed in the template. For example, you can do:
to add my-config-a and my-config-b to cilium-config. This could be
useful in case the template is missing some fields.
Ref: #13317
Signed-off-by: Michi Mutsuzaki michi@isovalent.com