build, ci: extend API checks to include Hubble API #14091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tklauser
added
area/CI-improvement
tklauser
force-pushed
the
pr/tklauser/ci-hubble-api-check
branch
from
ca6ed53
to
230db2f
Compare
Similar to the existing infrastructure to detect OpenAPI based changes, detect whether any of the Hubble API file need to be regenerated. This change also includes regeneration of `api/v1/flow/flow.pb.go` which was previously missed and the GitHub action would otherwise fail. Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
tklauser
force-pushed
the
pr/tklauser/ci-hubble-api-check
branch
from
230db2f
to
52904a6
Compare
rolinh
approved these changes
Nov 19, 2020
twpayne
approved these changes
Nov 19, 2020
|
The newly added target is used by the "Go-related checks" GitHub action which passed. Full CI run isn't necessary, marking as ready to merge. Also marked for backport to 1.8 and 1.9 as it might help to catch missing API re-generation in backport PRs. |
tklauser
added
ready-to-merge
This was referenced Nov 21, 2020
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.9
in 1.9.1
maintainer-s-little-helper
bot
moved this from Backport pending to v1.9
to Backport done to v1.9
in 1.9.1
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.8
in 1.8.6
maintainer-s-little-helper
bot
moved this from Backport pending to v1.8
to Needs backport from master
in 1.8.6
maintainer-s-little-helper
bot
moved this from Backport pending to v1.8
to Needs backport from master
in 1.8.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the existing infrastructure to detect OpenAPI based changes,
detect whether any of the Hubble API file need to be regenerated.
This change also includes regeneration of
api/v1/flow/flow.pb.gowhichwas previously missed and the GitHub action would otherwise fail.