-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rawgit links in README.rst #14092
Conversation
Commit 89e0165ab251629dd16db115a450e6e577b34f73 does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
test-me-please |
Commits 89e0165ab251629dd16db115a450e6e577b34f73, eb3d8accf29370d30ce1bee6dbe7310ca15a5a51 do not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for picking this up!
You just need to update the commits to include your signoff per the docs page:
You can achieve this by using git rebase --interactive origin/master
, then using "fixup" to squash the second patch into the first, then "git commit --amend -s" to add your sign-off line to the commit message. Then git push --force origin
to update the branch on Github.
@joestringer I have added the signed-off acknowledgement in the above comment itself. Sorry, I'm extremely new to open source PR. Just wanted to do this documentation before looking into more issues in the cilium. I ran into an error when I tried the above commands you mentioned after fetching the repo. ' fatal: Needed a single revision ' |
Signed-off-by: Vigneshwaren Sunder <vickymailed@gmail.com>
I fixed it up using your sign-off from the description, thanks! Feel free to drop by the Cilium Slack if you need help with developing Cilium in future :-) |
Signed-off-by: Vigneshwaren Sunder vickymailed@gmail.com
Fixes: #14082
Updated readme images as Rawgit is getting shutdown. Updated the cdn.rawgit.com to cdn.jsdelivr.net