Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rawgit links in README.rst #14092

Merged
merged 1 commit into from
Nov 20, 2020
Merged

Conversation

vignesh-codes
Copy link
Contributor

@vignesh-codes vignesh-codes commented Nov 19, 2020

Signed-off-by: Vigneshwaren Sunder vickymailed@gmail.com

Fixes: #14082

Updated readme images as Rawgit is getting shutdown. Updated the cdn.rawgit.com to cdn.jsdelivr.net

@maintainer-s-little-helper
Copy link

Commit 89e0165ab251629dd16db115a450e6e577b34f73 does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Nov 19, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Nov 19, 2020
@vignesh-codes vignesh-codes changed the title Fix rawgit links in README.rst - Updated with jsDelivr cdn Fix rawgit links in README.rst #14082 Nov 19, 2020
@vignesh-codes vignesh-codes changed the title Fix rawgit links in README.rst #14082 Fix rawgit links in README.rst Nov 19, 2020
@vignesh-codes
Copy link
Contributor Author

test-me-please

@maintainer-s-little-helper
Copy link

Commits 89e0165ab251629dd16db115a450e6e577b34f73, eb3d8accf29370d30ce1bee6dbe7310ca15a5a51 do not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up!

You just need to update the commits to include your signoff per the docs page:

https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

You can achieve this by using git rebase --interactive origin/master, then using "fixup" to squash the second patch into the first, then "git commit --amend -s" to add your sign-off line to the commit message. Then git push --force origin to update the branch on Github.

@joestringer joestringer added the release-note/misc This PR makes changes that have no direct user impact. label Nov 19, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 19, 2020
@vignesh-codes
Copy link
Contributor Author

@joestringer I have added the signed-off acknowledgement in the above comment itself. Sorry, I'm extremely new to open source PR. Just wanted to do this documentation before looking into more issues in the cilium.

I ran into an error when I tried the above commands you mentioned after fetching the repo.

' fatal: Needed a single revision '

Signed-off-by: Vigneshwaren Sunder <vickymailed@gmail.com>
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Nov 19, 2020
@joestringer
Copy link
Member

I fixed it up using your sign-off from the description, thanks!

Feel free to drop by the Cilium Slack if you need help with developing Cilium in future :-)

@joestringer joestringer merged commit 589bfe9 into cilium:master Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Fix rawgit links in README.rst
3 participants