test: Use stable tags instead of :latest #14093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchaigno
added
area/CI
pchaigno
force-pushed
the
pr/pchaigno/remove-latest-image-pulls
branch
2 times, most recently
from
e93eead
to
3d3064b
Compare
We use the latest tag for several of the Docker images in tests. That has two drawbacks: (1) unless imagePullPolicy is specified, we always attempts to pull the image and (2) we will start using new latest images as soon as they are available, which can cause our tests to flake. This commit avoids such use of latest to prefer an equivalent stable tag. When a stable tag did not already exist, 1.0 was created. When a source code repository existed for the image, a 1.0 GitHub release was created. When the source code wasn't available, the 1.0 image tag is simply a copy of current latest tag. Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
force-pushed
the
pr/pchaigno/remove-latest-image-pulls
branch
from
3d3064b
to
186902d
Compare
brb
approved these changes
Nov 20, 2020
|
None of the runtime tests cover changes in this PR, so the RuntimePrivilegedUnitTests failure appears to be a flake. I filed #14125 for it. Marking as ready to merge. |
pchaigno
added
the
ready-to-merge
pchaigno
added a commit
to cilium/packer-ci-build
that referenced
this pull request
Nov 23, 2020
Pull request cilium/cilium#14093 removed all references to :latest in our tests, prefering stable image tags. This pull request updates the list of pre-pulled images accordingly. Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
added a commit
to cilium/packer-ci-build
that referenced
this pull request
Nov 23, 2020
Pull request cilium/cilium#14093 removed all references to :latest in our tests, preferring stable image tags. This pull request updates the list of pre-pulled images accordingly. Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
added a commit
to cilium/packer-ci-build
that referenced
this pull request
Nov 25, 2020
Pull request cilium/cilium#14093 removed all references to :latest in our tests, preferring stable image tags. This pull request updates the list of pre-pulled images accordingly. Signed-off-by: Paul Chaignon <paul@cilium.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use the
latesttag for several of the Docker images in tests. That has two drawbacks: (1) unlessimagePullPolicyis specified, we always attempts to pull the image and (2) we will start using newlatestimages as soon as they are available, which can cause our tests to flake.This pull request avoids such use of
latestto prefer an equivalent stable tag. When a stable tag did not already exist,1.0was created. When a source code repository existed for the image, a1.0GitHub release was created. When the source code wasn't available, the1.0image tag is simply a copy of currentlatesttag.Fixes: #4483