endpoint: Add DebugPolicy option #14112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrajahalme
added
sig/policy
|
test-me-please |
ianvernon
approved these changes
Nov 23, 2020
nebril
approved these changes
Nov 23, 2020
aanm
approved these changes
Nov 23, 2020
jibi
approved these changes
Nov 23, 2020
pchaigno
approved these changes
Nov 23, 2020
|
test-me-please |
|
retest-4.9 |
kaworu
reviewed
Nov 24, 2020
| @@ -114,3 +139,61 @@ func (e *Endpoint) UpdateLogger(fields map[string]interface{}) { | |||
|
|
|||
| atomic.StorePointer(&e.logger, unsafe.Pointer(l)) | |||
| } | |||
|
|
|||
| func (e *Endpoint) updatePolicyLogger(fields map[string]interface{}) { | |||
There was a problem hiding this comment.
The caller need to hold Endpoint.mutex for writing correct? If yes, can we add a comment please?
About UpdateLogger comment on holding the mutex, my understanding is that the caller must hold Endpoint.mutex (not Endpoint.Mutex) for writing (not for reading) even when fields is nil as we can reach the atomic.StorePointer at line 140.
There was a problem hiding this comment.
I'll update the locking comments ;-)
Add endpoint DebugPolicy option that, if enabled, logs endpoint policy map update details to /var/run/cilium/state/endpoint-policy.log. The new DebugPolicy option is enabled if the new flag --debug-verbose=policy is set, but can be enabled also independently via: cilium endpoint config <EPID> DebugPolicy=true Signed-off-by: Martynas Pumputis <m@lambda.lt> Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
Endpoint's Mutex has been renamed as 'mutex'. Update comments to reflect this and also the lock level requirement (Lock for writing, RLock for reading). Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
jrajahalme
force-pushed
the
pr/jrajahalme/log-sync-policy
branch
from
ec51408
to
4d922b4
Compare
|
All tests passed before adding changes to comments only, no need to retest. |
jrajahalme
added
the
ready-to-merge
This was referenced Nov 30, 2020
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.8
in 1.8.6
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.9
in 1.9.1
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.9
in 1.9.1
maintainer-s-little-helper
bot
moved this from Backport pending to v1.9
to Backport done to v1.9
in 1.9.1
maintainer-s-little-helper
bot
moved this from Backport pending to v1.8
to Backport done to v1.8
in 1.8.6
This was referenced Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add endpoint DebugPolicy option that, if enabled, logs endpoint policy
map update details to /var/run/cilium/state/endpoint-policy.log.
The new DebugPolicy option is enabled if the new flag
--debug-verbose=policy is set, but can be enabled also independently
via:
cilium endpoint config DebugPolicy=true
This feature was first developed in the v1.7 branch, so no 1.7 backport is needed.
Signed-off-by: Martynas Pumputis m@lambda.lt
Signed-off-by: Jarno Rajahalme jarno@covalent.io