Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate ec2 client create call #14121

Merged
merged 1 commit into from
Nov 27, 2020
Merged

Consolidate ec2 client create call #14121

merged 1 commit into from
Nov 27, 2020

Conversation

ungureanuvladvictor
Copy link
Member

Signed-off-by: Vlad Ungureanu vladu@palantir.com

Consolidate ec2 client create call

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 22, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Nov 22, 2020
@ungureanuvladvictor ungureanuvladvictor added the release-note/misc This PR makes changes that have no direct user impact. label Nov 22, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 22, 2020
@ungureanuvladvictor
Consolidate ec2 client create call
22791e6 
Signed-off-by: Vlad Ungureanu <vladu@palantir.com>
@ungureanuvladvictor
Copy link
Member Author

test-me-please

@ungureanuvladvictor ungureanuvladvictor marked this pull request as ready for review November 22, 2020 04:58
@ungureanuvladvictor ungureanuvladvictor requested a review from a team as a code owner November 22, 2020 04:58
@ungureanuvladvictor ungureanuvladvictor requested review from a team and tgraf November 22, 2020 04:58
@ungureanuvladvictor ungureanuvladvictor added area/eni Impacts ENI based IPAM. area/operator Impacts the cilium-operator component labels Nov 22, 2020
@ungureanuvladvictor
Copy link
Member Author

ungureanuvladvictor commented Nov 26, 2020 •
edited

//edit: quay.io was down
retest-gke

@aanm aanm added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 26, 2020
@errordeveloper errordeveloper merged commit 9dc8130 into master Nov 27, 2020
@errordeveloper errordeveloper deleted the vladu/consolidate-ec2-client branch November 27, 2020 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christarazi christarazi christarazi approved these changes

@aanm aanm aanm approved these changes

@tgraf tgraf Awaiting requested review from tgraf

Assignees

@tgraf tgraf

Labels
area/eni Impacts ENI based IPAM. area/operator Impacts the cilium-operator component ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.10.0
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ungureanuvladvictor @christarazi @aanm @errordeveloper @tgraf