Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Collect object file artifacts for K8sVerifier #14129

Merged
merged 2 commits into from
Nov 24, 2020

Conversation

pchaigno
Copy link
Member

This PR first simplifies a little the K8sVerifier test by defining a working directory for the pod, then adds collection of all bpf_*.o artifacts if the test fails, to help debugging failures.

@pchaigno pchaigno added area/CI Continuous Integration testing issue or flake area/CI-improvement Topic or proposal to improve the Continuous Integration workflow release-note/ci This PR makes changes to the CI. labels Nov 23, 2020
@pchaigno pchaigno requested a review from a team as a code owner November 23, 2020 15:27
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Nov 23, 2020
@pchaigno pchaigno requested a review from brb November 23, 2020 15:27
@pchaigno
Copy link
Member Author

pchaigno commented Nov 23, 2020

Only K8sVerifier is affected by this pull request and this test only runs on our 4.9 pipeline for now.

test-4.9

@pchaigno pchaigno added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. and removed ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels Nov 24, 2020
Signed-off-by: Paul Chaignon <paul@cilium.io>
Signed-off-by: Paul Chaignon <paul@cilium.io>
@pchaigno pchaigno force-pushed the pr/pchaigno/artifacts-for-k8sverifier branch from 8827af3 to 53f73b2 Compare November 24, 2020 09:07
@pchaigno pchaigno removed the request for review from brb November 24, 2020 09:07
@pchaigno pchaigno added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 24, 2020
@aditighag aditighag merged commit eeecf15 into master Nov 24, 2020
@aditighag aditighag deleted the pr/pchaigno/artifacts-for-k8sverifier branch November 24, 2020 18:11
@pchaigno
Copy link
Member Author

pchaigno commented Nov 8, 2021

Marking for backports to v1.9 to simplify backporting of #17470.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake area/CI-improvement Topic or proposal to improve the Continuous Integration workflow ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants