ci: Check gke cluster state before selecting it #14130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
|
test-gke |
nebril
added
ready-to-merge
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
|
Since this only affects gke cluster selection process, marking this as ready to merge. |
christarazi
approved these changes
Nov 23, 2020
|
Commit e32ed6a465202d5503a794284d28c475546782b4 does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
maintainer-s-little-helper
bot
added
the
dont-merge/needs-sign-off
This change adds a check that confirms that GKE cluster is in running state, which prevents build from failing when apiserver is already up, but cluster is still being provisioned. Signed-off-by: Maciej Kwiek <maciej@isovalent.com>
nebril
force-pushed
the
pr/fix-select-cluster-gke
branch
from
e32ed6a
to
08698cd
Compare
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-sign-off
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a check that confirms that GKE cluster is in running
state, which prevents build from failing when apiserver is already up,
but cluster is still being provisioned.
This kind of failure could be seen in this build: https://jenkins.cilium.io/job/Ginkgo-CI-Tests-Pipeline-GKE/2391/execution/node/112/log/