Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Quarantine flakes from k8s-all CI pipeline #14151

Merged
merged 1 commit into from
Nov 25, 2020

Conversation

pchaigno
Copy link
Member

@pchaigno pchaigno commented Nov 24, 2020

Check vxlan connectivity with per-endpoint routes and Check iptables masquerading with random-fully are currently failing on the kubernetes-all CI pipeline for most K8s versions. This pull request quarantines those tests.

The list of K8s versions to exclude was retrieved using this CI dashboard report.

@pchaigno pchaigno added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. ci/flake This is a known failure that occurs in the tree. Please investigate me! labels Nov 24, 2020
@pchaigno pchaigno requested a review from nebril November 24, 2020 15:29
@pchaigno pchaigno requested a review from a team as a code owner November 24, 2020 15:29
@pchaigno pchaigno added this to In Progress (Cilium) in CI Force via automation Nov 24, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Nov 24, 2020
@nebril
Copy link
Member

nebril commented Nov 24, 2020

test-missed-k8s

Copy link
Member

@christarazi christarazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor nit. It would be helpful to note why those K8s versions specifically need to be skipped.

test/helpers/utils.go Show resolved Hide resolved
@pchaigno pchaigno force-pushed the pr/pchaigno/quarantine-k8s-all-flakes branch from 7a86891 to 4cd25d5 Compare November 25, 2020 08:03
"Check vxlan connectivity with per-endpoint routes" and "Check iptables
masquerading with random-fully" are currently failing on the
kubernetes-all CI pipeline for most K8s versions. This commit
quarantines those tests.

The list of K8s versions to exclude was retrieved using the CI
dashboard [1].

1 - https://datastudio.google.com/s/iCx91Z2LNH8
Signed-off-by: Paul Chaignon <paul@cilium.io>
@pchaigno
Copy link
Member Author

It would be helpful to note why those K8s versions specifically need to be skipped.

The pull request description and the commit message point to the CI dashboard report used to infer the K8s versions. I also added a comment in the code, but not sure it's telling anything more than helpers.SkipQuarantined already does.

@pchaigno pchaigno force-pushed the pr/pchaigno/quarantine-k8s-all-flakes branch from 4cd25d5 to a1f6142 Compare November 25, 2020 08:06
@nebril
Copy link
Member

nebril commented Nov 25, 2020

k8s-all failure is a known flake tracked by @pchaigno . merging

@nebril nebril merged commit 7570d08 into master Nov 25, 2020
CI Force automation moved this from In Progress (Cilium) to Fixed / Done Nov 25, 2020
@nebril nebril deleted the pr/pchaigno/quarantine-k8s-all-flakes branch November 25, 2020 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake ci/flake This is a known failure that occurs in the tree. Please investigate me! release-note/ci This PR makes changes to the CI.
Projects
No open projects
CI Force
  
Fixed / Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants