Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.travis: Run race detection builds on master commits only #14189

Merged

Conversation

pchaigno
Copy link
Member

We had to temporarily subscribe to Travis CI because we consumed our 10000 free credits. Our current plan however only allows for two concurrent builds. With four builds per commit, we are constantly running behind, with Travis CI builds now taking longer to be scheduled than it takes our Jenkins tests to finish. Long gone are the days when we considered Travis CI a viable smoke test...

This pull request attempts to alleviate the issue by running our race detection builds only on master commits.

@pchaigno pchaigno added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. labels Nov 26, 2020
@pchaigno pchaigno requested a review from aanm November 26, 2020 18:22
@pchaigno pchaigno requested a review from a team as a code owner November 26, 2020 18:22
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Nov 26, 2020
@pchaigno pchaigno marked this pull request as draft November 26, 2020 18:24
We had to temporarily subscribe to Travis CI because we consumed our
10000 free credits. Our current plan however only allows for two
concurrent builds. With four builds per commit, we are constantly
running behind, with Travis CI builds now taking longer to be scheduled
than it takes our Jenkins tests to finish. Long gone are the days when
we considered Travis CI a viable smoke test...

This commit attempts to alleviate the issue by running our race
detection builds only on master commits.

Signed-off-by: Paul Chaignon <paul@cilium.io>
@pchaigno pchaigno force-pushed the pr/pchaigno/reduce-rate-travis-race-detection-builds branch from b431439 to f231119 Compare November 26, 2020 18:26
@pchaigno pchaigno marked this pull request as ready for review November 26, 2020 18:28
@pchaigno
Copy link
Member Author

It's been 2 hours and Travis hasn't even started the build for this PR 😱

@pchaigno pchaigno added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 27, 2020
@errordeveloper errordeveloper merged commit 6d0a431 into master Nov 27, 2020
@errordeveloper errordeveloper deleted the pr/pchaigno/reduce-rate-travis-race-detection-builds branch November 27, 2020 10:12
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.9.1 Dec 3, 2020
@pchaigno
Copy link
Member Author

pchaigno commented Dec 3, 2020

I'm marking this pull request for backports into v1.9 because the v1.9 backport PRs are still frequent enough that they cause our Travis CI queue to lag behind.

@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.9 in 1.9.1 Dec 4, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.9 to Backport done to v1.9 in 1.9.1 Dec 4, 2020
@aanm aanm mentioned this pull request Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
No open projects
1.9.1
Backport done to v1.9
Development

Successfully merging this pull request may close these issues.

None yet

3 participants