Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

daemon_main: fix comments error #14194

Merged
merged 1 commit into from
Nov 27, 2020
Merged

daemon_main: fix comments error #14194

merged 1 commit into from
Nov 27, 2020

Conversation

lrouter
Copy link
Contributor

@lrouter lrouter commented Nov 27, 2020

The "option.Confog" is replaced with "option.Config" in comments.

Signed-off-by: fankaixi.li fankaixi.li@bytedance.com

The option.Confog is replaced with option.Config.

Signed-off-by: fankaixi.li <fankaixi.li@bytedance.com>
@lrouter lrouter requested review from a team and jibi November 27, 2020 02:05
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 27, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Nov 27, 2020
@twpayne twpayne added the release-note/misc This PR makes changes that have no direct user impact. label Nov 27, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 27, 2020
Copy link
Contributor

@twpayne twpayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix :)

@kaworu kaworu added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. priority/low This is considered nice to have. labels Nov 27, 2020
Copy link
Member

@kaworu kaworu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aanm aanm merged commit fd88d18 into cilium:master Nov 27, 2020
@lrouter lrouter deleted the fix_comment branch November 30, 2020 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. priority/low This is considered nice to have. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants