test: add nil check to CiliumReport to prevent segfaults #14210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If kubectl fails to initialize, most test suites will try to run CiliumReport to get cluster state, which will cause a segmentation fault since kubectl is nil. This change will give us a bit more visibility into these CI failures. Signed-off-by: Maciej Kwiek <maciej@isovalent.com>
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
|
test-me-please |
|
Example failure with segfault: https://jenkins.cilium.io/job/cilium-master-K8s-all/515/execution/node/161/log/ |
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
kkourt
approved these changes
Dec 1, 2020
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If kubectl fails to initialize, most test suites will try to run
CiliumReport to get cluster state, which will cause a segmentation fault
since kubectl is nil. This change will give us a bit more visibility
into these CI failures.