Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Correct typo in upgrade notes #14214

Merged
merged 1 commit into from
Nov 30, 2020
Merged

docs: Correct typo in upgrade notes #14214

merged 1 commit into from
Nov 30, 2020

Conversation

sayboras
Copy link
Member

@sayboras sayboras commented Nov 30, 2020 •
edited
Loading

Relates to 5db47e3

Signed-off-by: Tam Mach sayboras@yahoo.com

My bad 😓

@sayboras
docs: Correct typo in upgrade notes
7c4587a 
Relates to 5db47e3

Signed-off-by: Tam Mach <sayboras@yahoo.com>
@sayboras sayboras requested a review from a team as a code owner November 30, 2020 11:36
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 30, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Nov 30, 2020
@sayboras sayboras added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Nov 30, 2020
qmonnet
qmonnet approved these changes Nov 30, 2020
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix 👍

@qmonnet qmonnet added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 30, 2020
@qmonnet qmonnet removed their assignment Nov 30, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.9.1 Nov 30, 2020
@joestringer joestringer merged commit d390b97 into cilium:master Nov 30, 2020
@sayboras sayboras deleted the docs/typo branch November 30, 2020 21:50
@borkmann borkmann mentioned this pull request Dec 2, 2020
Merged
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.9 in 1.9.1 Dec 2, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.9 to Backport done to v1.9 in 1.9.1 Dec 3, 2020
@aanm aanm mentioned this pull request Dec 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolinh rolinh rolinh approved these changes

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.10.0
Done
1.9.1
Backport done to v1.9
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@sayboras @rolinh @qmonnet @borkmann @joestringer @pchaigno