bpf: revert changes to metrics directions contants #14217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
|
test-me-please |
jibi
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
jibi
added
sig/datapath
pchaigno
approved these changes
Nov 30, 2020
fristonio
approved these changes
Nov 30, 2020
This commit partially reverts commit 38ab8f0 ("bpf: add support for SERVICE metrics") by bringing the `METRIC_INGRESS` and `METRIC_EGRESS` constants back to their original values. In addition to that, it introduces the `ct_to_metrics_dir` helper which allows to convert a CT direction into the corresponding metric one. This mitigates any upgrade/downgrade impact caused by having keys with 2 different formats on the metrics map. Fixes: #14175 Signed-off-by: Gilberto Bertin <gilberto@isovalent.com>
jibi
force-pushed
the
pr/jibi/revert-metrics-directions-changes
branch
from
b49a286
to
dbd0f49
Compare
|
test-me-please |
maintainer-s-little-helper
bot
added
the
ready-to-merge
joestringer
approved these changes
Nov 30, 2020
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.9
in 1.9.1
maintainer-s-little-helper
bot
moved this from Backport pending to v1.9
to Backport done to v1.9
in 1.9.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit partially reverts commit 38ab8f0 ("bpf: add support for
SERVICE metrics") by bringing the
METRIC_INGRESSandMETRIC_EGRESSconstants back to their original values.
In addition to that, it introduces the
ct_to_metrics_dirhelper whichallows to convert a CT direction into the corresponding metric one.
This mitigates any upgrade/downgrade impact caused by having keys with 2
different formats on the metrics map.
Fixes: #14175