Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: Fix cilium/arping goroutine leak #14222

Merged
merged 1 commit into from
Dec 1, 2020

Conversation

jrajahalme
Copy link
Member

@jrajahalme jrajahalme commented Nov 30, 2020

This fixes a privileged runtime test failure caused by leaked goroutines on arpings with no response.

Signed-off-by: Jarno Rajahalme jarno@covalent.io

Fixed Goroutine leak for unresponded ARP pings.

This fixes a privileged runtime test failure caused by leaked goroutines on arpings with no response.

Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
@jrajahalme jrajahalme added kind/bug This is a bug in the Cilium logic. release-note/bug This PR fixes an issue in a previous release of Cilium. needs-backport/1.7 labels Nov 30, 2020
@jrajahalme jrajahalme requested a review from a team as a code owner November 30, 2020 16:33
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Nov 30, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.7.12 Nov 30, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.9.1 Nov 30, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.8.6 Nov 30, 2020
@jrajahalme
Copy link
Member Author

test-me-please

@jrajahalme
Copy link
Member Author

jrajahalme commented Dec 1, 2020

Travis on arm64 failed due to docker rate limiting:

toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit

restarted Travis job..

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Dec 1, 2020
@borkmann borkmann merged commit 24d4450 into master Dec 1, 2020
@borkmann borkmann deleted the pr/jrajahalme/arping-goroutine-leak-fix branch December 1, 2020 07:29
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.9 in 1.9.1 Dec 2, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.7 in 1.7.12 Dec 2, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.8 in 1.8.6 Dec 2, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.9 to Backport done to v1.9 in 1.9.1 Dec 3, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.7 to Backport done to v1.7 in 1.7.12 Dec 3, 2020
@aanm aanm mentioned this pull request Dec 4, 2020
@aanm aanm mentioned this pull request Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug This is a bug in the Cilium logic. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
No open projects
1.7.12
Backport done to v1.7
1.8.6
Backport pending to v1.8
1.9.1
Backport done to v1.9
Development

Successfully merging this pull request may close these issues.

None yet

8 participants