Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-doctor: Add more checks #14229

Merged
merged 4 commits into from
Dec 2, 2020
Merged

dev-doctor: Add more checks #14229

merged 4 commits into from
Dec 2, 2020

Conversation

twpayne
Copy link
Contributor

@twpayne twpayne commented Dec 1, 2020

See individual commits for details.

@twpayne
dev-doctor: Don't include Go patch version in check
7c3422c 
Signed-off-by: Tom Payne <tom@isovalent.com>
@twpayne twpayne requested review from a team as code owners December 1, 2020 11:34
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Dec 1, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Dec 1, 2020
@twpayne twpayne added the release-note/misc This PR makes changes that have no direct user impact. label Dec 1, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Dec 1, 2020
@twpayne twpayne requested a review from tklauser December 1, 2020 11:34
@twpayne twpayne added the area/build Anything to do with the build, more general then area/CI label Dec 1, 2020
tklauser
tklauser requested changes Dec 1, 2020
View reviewed changes
tools/dev-doctor/rootcmd.go Outdated Show resolved Hide resolved
@twpayne
dev-doctor: Add make binary check
ef2c9ef 
Signed-off-by: Tom Payne <tom@isovalent.com>
@twpayne
dev-doctor: Reduce severity of missing optional binaries
339b5d6 
Signed-off-by: Tom Payne <tom@isovalent.com>
@twpayne
dev-doctor: Add llc binary check
7ba10b5 
Signed-off-by: Tom Payne <tom@isovalent.com>
tklauser
tklauser approved these changes Dec 1, 2020
View reviewed changes
Copy link
Member

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@twpayne
Copy link
Contributor Author

twpayne commented Dec 2, 2020

I don't think this PR needs a full CI run so marking it ready to merge.

@twpayne twpayne added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Dec 2, 2020
@kkourt kkourt merged commit 6ae8588 into master Dec 2, 2020
@kkourt kkourt deleted the pr/twpayne/more-dev-doctor branch December 2, 2020 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tklauser tklauser tklauser approved these changes

@michi-covalent michi-covalent Awaiting requested review from michi-covalent

Assignees

@tklauser tklauser

@michi-covalent michi-covalent

Labels
area/build Anything to do with the build, more general then area/CI ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.10.0
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@twpayne @tklauser @kkourt @michi-covalent