vendor: update etcd to 3.4.14 #14238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This version fixes etcd error "auth token invalid after watch reconnects" etcd-io/etcd#11954. Signed-off-by: André Martins <andre@cilium.io>
aanm
added
kind/bug
|
test-me-please |
christarazi
approved these changes
Dec 2, 2020
tklauser
approved these changes
Dec 2, 2020
rolinh
reviewed
Dec 2, 2020
| @@ -73,7 +73,7 @@ require ( | |||
| github.com/stretchr/testify v1.6.1 | |||
| github.com/vishvananda/netlink v1.1.1-0.20200603190939-5a869a71f0cb | |||
| github.com/vishvananda/netns v0.0.0-20191106174202-0a2b9b5464df | |||
| go.etcd.io/etcd v0.5.0-alpha.5.0.20200824191128-ae9734ed278b | |||
| go.etcd.io/etcd v0.5.0-alpha.5.0.20201125193152-8a03d2e9614b | |||
There was a problem hiding this comment.
Isn't it possible to go get the version rather than the git sha so we'd have go.etcd.io/etcd v3.4.14? Looking at this line, it seems we're importing a very alpha version although we're not and we can't tell which version it is at first glance.
There was a problem hiding this comment.
@rolinh no, go get will complain, I usually copy-paste the commit sha into the repository to confirm which version is it.
rolinh
approved these changes
Dec 2, 2020
|
retest-gke |
|
restart-gke |
|
retest-gke |
maintainer-s-little-helper
bot
added
the
ready-to-merge
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.8
in 1.8.6
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.7
in 1.7.12
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.9
in 1.9.1
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.9
in 1.9.1
maintainer-s-little-helper
bot
moved this from Backport pending to v1.9
to Backport done to v1.9
in 1.9.1
maintainer-s-little-helper
bot
moved this from Backport pending to v1.9
to Backport done to v1.9
in 1.9.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version fixes etcd error "auth token invalid after
watch reconnects". etcd-io/etcd#11954
Signed-off-by: André Martins andre@cilium.io