CODEOWNERS: Split test/ code owners #14244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchaigno
added
area/CI
pchaigno
commented
Dec 2, 2020
pchaigno
commented
Dec 2, 2020
pchaigno
commented
Dec 2, 2020
aanm
approved these changes
Dec 3, 2020
christarazi
approved these changes
Dec 3, 2020
joestringer
approved these changes
Dec 3, 2020
qmonnet
approved these changes
Dec 4, 2020
Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
force-pushed
the
pr/pchaigno/split-ci-codeowners
branch
from
f33c5b2
to
fd1dc9e
Compare
|
After discussion with André and Maciej, I've reworked several files in I've re-requested all your reviews because you should know better than to review a draft pull request 😝 |
|
test-nightly |
qmonnet
approved these changes
Dec 8, 2020
Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
force-pushed
the
pr/pchaigno/split-ci-codeowners
branch
from
fd1dc9e
to
62e93db
Compare
PoliciesNightly are still executed and should remain. Signed-off-by: Paul Chaignon <paul@cilium.io>
Suggested-by: Maciej Kwiek <maciej@isovalent.com> Signed-off-by: Paul Chaignon <paul@cilium.io>
The cilium/ci team (renamed in this commit to cilium/ci-structure) is in charge of the CI infra. (e.g., Jenkinsfile, scripts, etc.), including the Go helper functions and the overall structure of our tests, but it doesn't have the charge of the actual testing logic. This commit splits the test/ code owners across team to better represents the actual owners of the testing logic. Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
force-pushed
the
pr/pchaigno/split-ci-codeowners
branch
from
62e93db
to
8ff2587
Compare
After discussion with Maciej, we decided to remove the Nightly test files (except for |
christarazi
approved these changes
Dec 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The @cilium/ci team (renamed in this pull request to @cilium/ci-structure) is in charge of the CI infra. (e.g., Jenkinsfile, scripts, etc.), including the Go helper functions and the overall structure of our tests, but it doesn't have the charge of the actual testing logic.
This pull request splits the
test/code owners across team to better represents the actual owners of the testing logic.I have been unable to assign the following files to specific teams and they are therefore matched by the @cilium/ci catch-all at the moment: