pkg/endpoint: Readd GetRealizedPolicyRuleLabelsForKey #14257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This brings back the GetRealizedPolicyRuleLabelsForKey helper which is used by external client code and was accidentally removed as unused. This commit also extends the Hubble unit tests to invoke it, to avoid another accidental removal. Fixes: 0ba1967 ("pkg/endpoint: remove unused functions") Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
gandro
added
release-note/misc
|
test-me-please |
kaworu
approved these changes
Dec 3, 2020
pchaigno
approved these changes
Dec 3, 2020
|
VM provisioning fail on runtime and 4.9: https://jenkins.cilium.io/job/Cilium-PR-Runtime-4.9/2842/ / https://jenkins.cilium.io/job/Cilium-PR-K8s-1.20-kernel-4.9/9/ |
|
retest-runtime |
|
retest-4.9 |
glibsm
approved these changes
Dec 3, 2020
jrajahalme
approved these changes
Dec 3, 2020
|
FWIW, removing GetRealizedPolicyRuleLabelsForKey breaks network policy logging on GKE too. |
|
I don't think we can ever remove exported functionality anymore given that Cilium is a dependency for Hubble, GKE network policy logging, etc. |
ianvernon
approved these changes
Dec 5, 2020
christarazi
approved these changes
Dec 7, 2020
|
retest-net-next Edit: VM provisioning fail |
aanm
approved these changes
Dec 7, 2020
|
retest-net-next Provisioning keeps failing https://jenkins.cilium.io/job/Cilium-PR-K8s-1.12-net-next/1512/ |
|
retest-net-next |
|
All required tests have passed. |
gandro
added
the
ready-to-merge
nebril
deleted the
pr/gandro/bring-back-getrealizedpolicyrulelabelsforkey
branch
joestringer
moved this from Needs backport from master
to Backport done to v1.9
in 1.9.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings back the GetRealizedPolicyRuleLabelsForKey helper which is
used by external client code and was accidentally removed as unused.
This commit also extends the Hubble unit tests to invoke it, to avoid
another accidental removal.
Fixes: 0ba1967 ("pkg/endpoint: remove unused functions")