Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Istio: Update to 1.6.14 #14271

Merged
merged 1 commit into from
Dec 30, 2020
Merged

Istio: Update to 1.6.14 #14271

merged 1 commit into from
Dec 30, 2020

Conversation

jrajahalme
Copy link
Member

@jrajahalme jrajahalme commented Dec 4, 2020

Update Istio integration to Istio release 1.6.14 now that 1.5.x is no longer supported.

Istio CI test is now unquarantined on K8s 1.19 and K8s 1.20.

Signed-off-by: Jarno Rajahalme jarno@covalent.io

Istio integration is updated to Istio release 1.6.14

@jrajahalme jrajahalme added kind/enhancement This would improve or streamline existing functionality. area/proxy Impacts proxy components, including DNS, Kafka, Envoy and/or XDS servers. release-note/minor This PR changes functionality that users may find relevant to operating Cilium. labels Dec 4, 2020
@jrajahalme jrajahalme requested review from a team as code owners December 4, 2020 09:17
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Dec 4, 2020
@jrajahalme
Copy link
Member Author

test-me-please

@jrajahalme jrajahalme marked this pull request as draft December 4, 2020 09:17
@jrajahalme
Copy link
Member Author

Using REDIRECT instead of TPROXY has a scenario where the original source address is lost. Specifically, if two connections from the same source are received for the same destination port, REDIRECT will do a source NAT to ensure unique 5-tuples. This will lead to incorrect source security ID mapping.

Upstream Istio is fixing TPROXY (istio/istio#28457), will keep this as draft for now.

@jrajahalme jrajahalme force-pushed the pr/jrajahalme/istio-1.6.14-update branch 2 times, most recently from 4e70786 to 5de94b8 Compare December 6, 2020 10:44
@jrajahalme
Copy link
Member Author

test-me-please

1 similar comment
@jrajahalme
Copy link
Member Author

test-me-please

@jrajahalme
Copy link
Member Author

retest-gke

@jrajahalme jrajahalme force-pushed the pr/jrajahalme/istio-1.6.14-update branch from 5de94b8 to 84117fc Compare December 7, 2020 00:04
@jrajahalme
Copy link
Member Author

test-me-please

@jrajahalme
Copy link
Member Author

retest-4.9

1 similar comment
@jrajahalme
Copy link
Member Author

retest-4.9

@jrajahalme jrajahalme force-pushed the pr/jrajahalme/istio-1.6.14-update branch from 84117fc to c9d6fcb Compare December 7, 2020 08:32
@jrajahalme
Copy link
Member Author

test-me-please

@jrajahalme
Copy link
Member Author

retest-4.9

@jrajahalme
Copy link
Member Author

retest-netnext

@jrajahalme
Copy link
Member Author

retest-net-next

@jrajahalme jrajahalme force-pushed the pr/jrajahalme/istio-1.6.14-update branch from c9d6fcb to aa4e97e Compare December 14, 2020 16:07
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not much to add to the other reviews. If anything, don't hesitate to split such PRs into several commits in the future, it might help with review and history :).

}

// Map of tested runtimes for cilium-istioctl
// Map for tested cilium-istioctl release targets if not GOOS-GORACH
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Map for tested cilium-istioctl release targets if not GOOS-GORACH
// Map for tested cilium-istioctl release targets if not GOOS-GOARCH

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks!

@qmonnet qmonnet removed their assignment Dec 22, 2020
@jrajahalme jrajahalme force-pushed the pr/jrajahalme/istio-1.6.14-update branch from 4df83b9 to 6fc09cb Compare December 30, 2020 00:53
Istio CI test was quarantined on K8s 1.19 and 1.20 due to `istioctl`
using deprecated k8s features and then returning a non-zero exit code
due to deprecation warnings from k8s. This release of `istioctl` fixes
that so the test can be unquarantined.

Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
@jrajahalme
Copy link
Member Author

test-me-please

@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.9.2 Dec 30, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Dec 30, 2020
@kkourt kkourt merged commit ae9f5ea into master Dec 30, 2020
@kkourt kkourt deleted the pr/jrajahalme/istio-1.6.14-update branch December 30, 2020 07:11
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.9 in 1.9.2 Jan 6, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.9 in 1.9.2 Jan 6, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.9 to Backport done to v1.9 in 1.9.2 Jan 14, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.9 to Backport done to v1.9 in 1.9.2 Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/proxy Impacts proxy components, including DNS, Kafka, Envoy and/or XDS servers. kind/enhancement This would improve or streamline existing functionality. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
No open projects
1.9.2
Backport done to v1.9
Development

Successfully merging this pull request may close these issues.

None yet

8 participants