-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Istio: Update to 1.6.14 #14271
Istio: Update to 1.6.14 #14271
Conversation
test-me-please |
Using REDIRECT instead of TPROXY has a scenario where the original source address is lost. Specifically, if two connections from the same source are received for the same destination port, REDIRECT will do a source NAT to ensure unique 5-tuples. This will lead to incorrect source security ID mapping. Upstream Istio is fixing TPROXY (istio/istio#28457), will keep this as draft for now. |
4e70786
to
5de94b8
Compare
test-me-please |
1 similar comment
test-me-please |
retest-gke |
5de94b8
to
84117fc
Compare
test-me-please |
retest-4.9 |
1 similar comment
retest-4.9 |
84117fc
to
c9d6fcb
Compare
test-me-please |
retest-4.9 |
retest-netnext |
retest-net-next |
c9d6fcb
to
aa4e97e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not much to add to the other reviews. If anything, don't hesitate to split such PRs into several commits in the future, it might help with review and history :).
test/k8sT/istio.go
Outdated
} | ||
|
||
// Map of tested runtimes for cilium-istioctl | ||
// Map for tested cilium-istioctl release targets if not GOOS-GORACH |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// Map for tested cilium-istioctl release targets if not GOOS-GORACH | |
// Map for tested cilium-istioctl release targets if not GOOS-GOARCH |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, thanks!
4df83b9
to
6fc09cb
Compare
Istio CI test was quarantined on K8s 1.19 and 1.20 due to `istioctl` using deprecated k8s features and then returning a non-zero exit code due to deprecation warnings from k8s. This release of `istioctl` fixes that so the test can be unquarantined. Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
6fc09cb
to
d3e2235
Compare
test-me-please |
Update Istio integration to Istio release 1.6.14 now that 1.5.x is no longer supported.
Istio CI test is now unquarantined on K8s 1.19 and K8s 1.20.
Signed-off-by: Jarno Rajahalme jarno@covalent.io