Vagrant: Add support for .devvmrc #14272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrajahalme
added
kind/enhancement
|
test-me-please |
jrajahalme
force-pushed
the
pr/jrajahalme/dev-vm-rc
branch
from
27eeca6
to
379699e
Compare
|
test-me-please |
pchaigno
approved these changes
Dec 4, 2020
test/Vagrantfile
Outdated
| # Disable unattended-upgrades to prevent it from holding the dpkg frontend lock | ||
| # To be removed once this has been added through packer-ci-build | ||
| sudo systemctl disable unattended-upgrades.service | ||
| sudo systemctl stop unattended-upgrades.service |
There was a problem hiding this comment.
We can now remove those lines, they are part of the VM images: cilium/packer-ci-build@af99f4c.
christarazi
approved these changes
Dec 4, 2020
Execute the file .devvmrc within the Developer VM and CI VMs, if it exists in the cilium repo. This allows for setting git config, docker registry caching, or any other personal settings for the Dev's environment automatically. Setting up /etc/hosts in k8s_install.sh is changed to append instead of replace, so that .devvmrc can add host entries without losing them right after when k8s_install runs. Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
jrajahalme
force-pushed
the
pr/jrajahalme/dev-vm-rc
branch
from
379699e
to
bacea09
Compare
|
@christarazi Added docs :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Execute the file .devvmrc within the Developer VM and CI VMs, if it
exists in the cilium repo. This allows for setting git config, docker
registry caching, or any other personal settings for the Dev's environment
automatically.
Setting up /etc/hosts in k8s_install.sh is changed to append instead
of replace, so that .devvmrc can add host entries without losing them
right after when k8s_install runs.
Signed-off-by: Jarno Rajahalme jarno@covalent.io