hubble: allow filtering by agent event subtypes #14305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When originally adding support for agent events in #14168, generic agent events were left out since there are non currently produced by the Cilium agent. However, this leads to a mismatch between the AgenteEventType_* values and the respective monitor API values. In order to allow filtering on agent event types these should match, so mark the value for generic agent events as reserved in enum AgenteEventType. Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Use the filter sub type to specify agent event type. Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
tklauser
added
release-note/minor
|
test-me-please |
rolinh
approved these changes
Dec 8, 2020
There was a problem hiding this comment.
I guess we still need to have an API discussion to know if #14242 (comment) also needs to be tackled.
|
retest-runtime hit #14125 https://jenkins.cilium.io/job/Cilium-PR-Runtime-4.9/2904/ |
|
retest-net-next hit #13261 https://jenkins.cilium.io/job/Cilium-PR-K8s-1.12-net-next/1543/ |
glibsm
approved these changes
Dec 8, 2020
tklauser
added
the
ready-to-merge
|
retest-4.19 |
|
retest-4.9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up for #14242
The first commit updates the protobuf enum values for the agent event types, so they match the respective monitor API values. This will make the implementation on the Hubble CLI side more straight-forward.
The second commit introduces functionality to filter agent events by event type (e.g. endpoint creation, policy update).