Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use host images in master job #14311

Merged
merged 1 commit into from
Dec 9, 2020
Merged

Conversation

nebril
Copy link
Member

@nebril nebril commented Dec 8, 2020

Since we started handling CILIUM_REGISTRY properly in vagrantfile, this
job started failing because it didn't build images in vms.

@nebril nebril requested a review from a team as a code owner December 8, 2020 18:21
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Dec 8, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Dec 8, 2020
@nebril nebril added the release-note/ci This PR makes changes to the CI. label Dec 8, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Dec 8, 2020
@nebril
Copy link
Member Author

nebril commented Dec 8, 2020

test-ginkgo

@nebril
Copy link
Member Author

nebril commented Dec 8, 2020

restart-ginkgo

@nebril
Copy link
Member Author

nebril commented Dec 9, 2020

looks like I messed up the path to print-node-ip.sh, will fix shortly

Since we started handling CILIUM_REGISTRY properly in vagrantfile, this
job started failing because it didn't build images in vms.

Signed-off-by: Maciej Kwiek <maciej@isovalent.com>
@nebril
Copy link
Member Author

nebril commented Dec 9, 2020

restart-ginkgo

@nebril nebril force-pushed the pr/use-host-images-in-master-job branch from 5ed7ecc to 8b0c10a Compare December 9, 2020 11:23
@nebril
Copy link
Member Author

nebril commented Dec 9, 2020

restart-ginkgo

@nebril nebril added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Dec 9, 2020
@nebril
Copy link
Member Author

nebril commented Dec 9, 2020

The only build that it touches has passed, merging https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/20032/

@nebril nebril merged commit 62bb78a into master Dec 9, 2020
@nebril nebril deleted the pr/use-host-images-in-master-job branch December 9, 2020 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants