Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

microk8s: fix add-on-command for enabling cilium #14325

Merged
merged 1 commit into from
Dec 10, 2020

Conversation

brandshaide
Copy link
Contributor

@brandshaide brandshaide commented Dec 9, 2020

As per Documentation of microk8s, enabling add-ons are being invoked with microk8s enable <addon> - note the missing dot
Also tested this locally

microk8s enable cilium

Signed-off-by: Philipp Gniewosz philipp.gniewosz@posteo.de

As per Documentation of microk8s (https://microk8s.io/docs/addons), enabling add-ons are being invoked with `microk8s enable <addon>` - note the missing „.“.
Also tested this locally

`microk8s enable cilium`

Signed-off-by: Philipp Gniewosz <philipp.gniewosz@posteo.de>
@brandshaide brandshaide requested a review from a team as a code owner December 9, 2020 11:54
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Dec 9, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Dec 9, 2020
@brandshaide brandshaide changed the title fix microk8s command to enable cilium microk8s: fix add-on-command for enabling cilium Dec 9, 2020
@joestringer joestringer added the release-note/misc This PR makes changes that have no direct user impact. label Dec 10, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Dec 10, 2020
@joestringer joestringer added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. needs-backport/1.9 labels Dec 10, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Dec 10, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.9.2 Dec 10, 2020
Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know this 😅 LGTM :)

@joestringer joestringer merged commit 431eda4 into cilium:master Dec 10, 2020
@brandshaide brandshaide deleted the feature/fix-command-microk8s branch December 10, 2020 18:28
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.9 in 1.9.2 Dec 15, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.9 in 1.9.2 Dec 15, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.9 to Backport done to v1.9 in 1.9.2 Dec 18, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.9 to Backport done to v1.9 in 1.9.2 Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.9.2
Backport done to v1.9
Development

Successfully merging this pull request may close these issues.

None yet

2 participants