maglev: Delete map if previous M's do not match #14345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
brb
changed the title
brb
added
the
release-note/bug
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
|
test-me-please |
brb
force-pushed
the
pr/brb/maglev-table-resize
branch
from
f646a2c
to
afcb86f
Compare
|
test-me-please |
pchaigno
approved these changes
Dec 10, 2020
@pchaigno It's being checked by https://github.com/cilium/cilium/blob/master/pkg/bpf/map_linux.go#L1129. However, as we are planning to migrate from |
|
Damn, we run the privileged tests on 4.9, and the map-in-map is not supported on that kernel. |
brb
force-pushed
the
pr/brb/maglev-table-resize
branch
from
afcb86f
to
b56d670
Compare
It was reported by a user, that when the M param
(--bpf-lb-maglev-table-size) changes, then the verifier is failing to
load the program on the 5.4 kernel with the following error:
invalid access to map value, value_size=32762 off=65520 size=2 R0
max value is outside of the array range processed 507 insns (limit
1000000) max_states_per_insn 1 total_states 34 peak_states 34
mark_read 17
Fix this by recreating the map when we detect that the M has changed.
Reported-by: Han Zhou <hzhou8@ebay.com>
Signed-off-by: Martynas Pumputis <m@lambda.lt>
brb
force-pushed
the
pr/brb/maglev-table-resize
branch
from
22d4385
to
8c7fade
Compare
|
test-me-please |
brb
force-pushed
the
pr/brb/maglev-table-resize
branch
from
8c7fade
to
d9afcd3
Compare
Move the GetKernelVersion() from pkg/datapath/linux to pkg/version so that it can be included by pkg/maps/lbmap which is included by pkg/datapath/linux. Otherwise, we have a circular dependency. Also, make the function to return an error instead of calling log.Fatal, as it's caller's responsibility to decide what to do with an error. Signed-off-by: Martynas Pumputis <m@lambda.lt>
Unfortunately, we run the privileged unit tests on the 4.9 kernel which does not have the map-in-map support. Therefore, add a skip based on the kernel version so that the CI does not fail. Signed-off-by: Martynas Pumputis <m@lambda.lt>
|
test-me-please |
|
retest-net-next |
|
net-next hit #12511. |
|
retest-net-next |
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.9
in 1.9.2
maintainer-s-little-helper
bot
moved this from Backport pending to v1.9
to Backport done to v1.9
in 1.9.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was reported by a user, that when the M param
(
--bpf-lb-maglev-table-size) changes, then the verifier is failing toload the program on the 5.4 kernel with the following error:
Fix this by recreating the map when we detect that the M has changed.
Fix: #14251
Reported-by: Han Zhou hzhou8@ebay.com