Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/logging: Init klog with flag set name #14346

Merged
merged 1 commit into from
Dec 17, 2020
Merged

Conversation

fafucoder
Copy link

@fafucoder fafucoder commented Dec 10, 2020

Previously, klog init flag with nil by using default flag commandline, if other operator
init flag by nil will result in flag log_dir redefined errors.

This commit resolved the log_dir flag redefined problem by instantiating flag.NewFlagSet

Fixes: #14317
Signed-off-by: fafucoder lx1960754013@gmail.com

@fafucoder fafucoder requested a review from a team as a code owner December 10, 2020 07:51
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Dec 10, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Dec 10, 2020
@tklauser tklauser requested a review from aanm December 10, 2020 09:11
@tklauser
Copy link
Member

Signed-off-by: André Martins andre@cilium.io

@fafucoder: Thanks for sending the PR. One remark regarding the Signed-off-by line: this should have your name and e-mail (also in the commit message), not the one from André. See https://docs.cilium.io/en/v1.9/contributing/development/contributing_guide/#dev-coo for more information.

Copy link
Member

@aanm aanm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides the sign-off email

@aanm aanm added needs-backport/1.8 release-note/misc This PR makes changes that have no direct user impact. labels Dec 10, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Dec 10, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.9.2 Dec 10, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.8.7 Dec 10, 2020
Previously, klog init flag with nil by using default flag commandline, if other operator
init flag by nil will result in flag log_dir redefined errors.

This commit resolved the log_dir flag redefined problem by instantiating flag.NewFlagSet

Fixes: cilium#14317
Signed-off-by: fafucoder <lx1960754013@gmail.com>
@fafucoder
Copy link
Author

@tklauser Thanks for reminding

Copy link
Contributor

@twpayne twpayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tklauser tklauser requested a review from aanm December 11, 2020 10:17
Copy link
Member

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fafucoder

@tklauser
Copy link
Member

test-me-please

@aanm
Copy link
Member

aanm commented Dec 11, 2020

retest-gke

@aanm
Copy link
Member

aanm commented Dec 11, 2020

retest-4.9

@aanm
Copy link
Member

aanm commented Dec 11, 2020

retest-runtime

@maintainer-s-little-helper maintainer-s-little-helper bot removed this from Needs backport from master in 1.8.7 Dec 17, 2020
@aanm aanm merged commit 95777d9 into cilium:master Dec 17, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.9 in 1.9.2 Jan 6, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.9 in 1.9.2 Jan 6, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.9 to Backport done to v1.9 in 1.9.2 Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.9.2
Backport done to v1.9
Development

Successfully merging this pull request may close these issues.

Cilium klog conflicts with other crd operators
5 participants