-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/logging: Init klog with flag set name #14346
Conversation
@fafucoder: Thanks for sending the PR. One remark regarding the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM besides the sign-off email
Previously, klog init flag with nil by using default flag commandline, if other operator init flag by nil will result in flag log_dir redefined errors. This commit resolved the log_dir flag redefined problem by instantiating flag.NewFlagSet Fixes: cilium#14317 Signed-off-by: fafucoder <lx1960754013@gmail.com>
@tklauser Thanks for reminding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fafucoder
test-me-please |
retest-gke |
retest-4.9 |
retest-runtime |
Previously, klog init flag with nil by using default flag commandline, if other operator
init flag by nil will result in flag log_dir redefined errors.
This commit resolved the log_dir flag redefined problem by instantiating flag.NewFlagSet
Fixes: #14317
Signed-off-by: fafucoder lx1960754013@gmail.com