pkg/logging: Init klog with flag set name #14346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
@fafucoder: Thanks for sending the PR. One remark regarding the |
aanm
added
needs-backport/1.8
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
Previously, klog init flag with nil by using default flag commandline, if other operator init flag by nil will result in flag log_dir redefined errors. This commit resolved the log_dir flag redefined problem by instantiating flag.NewFlagSet Fixes: cilium#14317 Signed-off-by: fafucoder <lx1960754013@gmail.com>
|
@tklauser Thanks for reminding |
|
test-me-please |
aanm
approved these changes
Dec 11, 2020
|
retest-gke |
|
retest-4.9 |
|
retest-runtime |
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.9
in 1.9.2
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.9
in 1.9.2
maintainer-s-little-helper
bot
moved this from Backport pending to v1.9
to Backport done to v1.9
in 1.9.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, klog init flag with nil by using default flag commandline, if other operator
init flag by nil will result in flag log_dir redefined errors.
This commit resolved the log_dir flag redefined problem by instantiating flag.NewFlagSet
Fixes: #14317
Signed-off-by: fafucoder lx1960754013@gmail.com