policy: Suppress any policy map updates when updating redirects if keeping the current policy #14356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrajahalme
added
kind/enhancement
|
test-me-please |
|
Known flake (#12511) on netnext, no other failures. |
christarazi
approved these changes
Dec 11, 2020
…eping the current policy Incremental policy update path (AccumulateMapChanges/ConsumeMapChanges) is taking care of the policy map updates when a full policy recalcualtion is not necessary. We already depended on this to get the redirect entries plumbed down to the bpf maps. Make this more explicit by suppressing policy MapState updates while updating proxy redirects if a new policy was not calculated. This allows ConsumeMapsChanges() to notice that the redirect entry was not already in the desired MapState and pass it along as a map change to be applied to the bpf maps. Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
jrajahalme
force-pushed
the
pr/jrajahalme/suppress-policy-map-update-when-updating-redirects
branch
from
5dbeb62
to
57701fa
Compare
|
test-me-please |
|
Rebase to master & retest. |
aanm
approved these changes
Dec 15, 2020
jrajahalme
added
the
ready-to-merge
kkourt
deleted the
pr/jrajahalme/suppress-policy-map-update-when-updating-redirects
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incremental policy update path
(AccumulateMapChanges/ConsumeMapChanges) is taking care of the policy
map updates when a full policy recalcualtion is not necessary. We
already depended on this to get the redirect entries plumbed down to
the bpf maps. Make this more explicit by suppressing policy MapState
updates while updating proxy redirects if a new policy was not
calculated. This allows ConsumeMapsChanges() to notice that the
redirect entry was not already in the desired MapState and pass it
along as a map change to be applied to the bpf maps.
Signed-off-by: Jarno Rajahalme jarno@covalent.io