policy: Track selectors that contribute to MapStateEntries #14362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ upstream commit 04840b9 ] Track which selectors in policy require a specific bpf policy map key to be present, and keep policy entries in the map as long as any selector requires it's presence. Without this it is possible for a timed-out DNS cache entry to clear a policy cache key that is still required by another selector (FQDN or CIDR). To implement this, each MapStateEntry is now equipped with a set of (cached) selectors through which the policy map key/value was added. 'nil' has the special significance that it is used as the CachedSelector in cases where the policy map entry is added due to some administrative or configuration reason. Currently incremental updates will never remove such entries. Incremental policy updates now simply collect the requested map changes. When the endpoint then pulls the changes they are first applied the desired policy map (MapState), while tallying which selectors still need the map entries to be present. The actual bpf map diffs are recorded based on the total count of selectors on each map entry. Signed-off-by: Jarno Rajahalme <jarno@covalent.io> Signed-off-by: Cilium Maintainers <maintainer@cilium.io>
jrajahalme
added
kind/backports
|
test-backport-1.9 |
|
test-gke |
1 similar comment
|
test-gke |
|
test-1.18-4.19 |
nebril
approved these changes
Dec 11, 2020
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ upstream commit 04840b9 ]
Track which selectors in policy require a specific bpf policy map key to
be present, and keep policy entries in the map as long as any selector
requires it's presence. Without this it is possible for a timed-out
DNS cache entry to clear a policy cache key that is still required by
another selector (FQDN or CIDR).
To implement this, each MapStateEntry is now equipped with a set of
(cached) selectors through which the policy map key/value was
added. 'nil' has the special significance that it is used as the
CachedSelector in cases where the policy map entry is added due to
some administrative or configuration reason. Currently incremental
updates will never remove such entries.
Incremental policy updates now simply collect the requested map
changes. When the endpoint then pulls the changes they are first
applied the desired policy map (MapState), while tallying which
selectors still need the map entries to be present. The actual bpf map
diffs are recorded based on the total count of selectors on each map
entry.
Signed-off-by: Jarno Rajahalme jarno@covalent.io