Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cilium: error out in svc upsert on frontend/backend ports mismatch on IPIP #14372

Merged
merged 1 commit into from
Dec 11, 2020
Merged

cilium: error out in svc upsert on frontend/backend ports mismatch on IPIP #14372

merged 1 commit into from
Dec 11, 2020

Conversation

borkmann
Copy link
Member

See commit msg.

@borkmann
cilium: error out in svc upsert on frontend/backend ports mismatch on…
8b77d6b 
… IPIP

Follow-up to address the case where frontend port != backend port in
DSR + IPIP mode, since IPIP assumes that both must match. Error out
with a user error so these cases don't accidentally get added to the
service table. Fwiw, I left ClusterIP aside since this is only to be
xlated on the local node directly but never for N-S traffic.

Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Link: #14193 (review)
@borkmann borkmann added pending-review release-note/misc This PR makes changes that have no direct user impact. feature/lb-only Impacts cilium running in lb-only datapath mode labels Dec 11, 2020
@borkmann borkmann requested review from brb and a team December 11, 2020 11:01
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Dec 11, 2020
@borkmann
Copy link
Member Author

test-me-please

@borkmann
Copy link
Member Author

retest-runtime

brb
brb approved these changes Dec 11, 2020
View reviewed changes
Copy link
Member

@brb brb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@borkmann borkmann merged commit cc5a29a into master Dec 11, 2020
@borkmann borkmann deleted the pr/port-match branch December 11, 2020 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brb brb brb approved these changes

Assignees

@brb brb

Labels
feature/lb-only Impacts cilium running in lb-only datapath mode release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.10.0
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@borkmann @brb