Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dev-docker-operator-image makefile directive #14387

Merged
merged 1 commit into from
Dec 15, 2020

Conversation

ungureanuvladvictor
Copy link
Member

While working on some cilium-operator features I needed to deploy this in an EKS cluster and the easiest way is to push it to a personal quay.iorepository and then update the cilium-operator deployment in EKS. With this a developer can do:

DOCKER_DEV_ACCOUNT=quay.io/$USERNAME DOCKER_IMAGE_TAG=new-feature make dev-docker-operator-image

This also applies for the rest of the operator cloud-provider specific images.

Add dev-docker-operator-image makefile directive

@ungureanuvladvictor ungureanuvladvictor requested a review from a team as a code owner December 12, 2020 23:25
@maintainer-s-little-helper
Copy link

Commit 34437851c1e3250af3c2941551640075af15603d does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Dec 12, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Dec 12, 2020
Signed-off-by: Vlad Ungureanu <vladu@palantir.com>
@maintainer-s-little-helper
Copy link

Commit 34437851c1e3250af3c2941551640075af15603d does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@ungureanuvladvictor ungureanuvladvictor added release-note/misc This PR makes changes that have no direct user impact. and removed dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. labels Dec 12, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Dec 12, 2020
@ungureanuvladvictor
Copy link
Member Author

test-me-please

@ungureanuvladvictor
Copy link
Member Author

retest-net-next

@ungureanuvladvictor
Copy link
Member Author

retest-4.9

@ungureanuvladvictor
Copy link
Member Author

retest-runtime

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Dec 14, 2020
Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't try it out, but it looks pretty similar to the other targets and I'm guessing you use this semi-regularly so 👍

@aanm aanm merged commit e3781bc into master Dec 15, 2020
@aanm aanm deleted the vladu/dev-cilium-operator branch December 15, 2020 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants