ci: Use correct agent value in preflight check

[gandro]

The K8sUpdates deploys the Helm preflight check on top of an existing
older Cilium installation. To deploy the preflight check, the agent
must be disabled. The flag to disable the agent has been renamed in the
Cilium 1.9 charts. Therefore the upgrade test needs to set the proper
value.

This fixes an issue with the upgrade test on GKE where it fails as
follows:

coalesce.go:165: warning: skipped value for agent: Not a table.
Error: rendered manifests contain a resource that already exists. Unable to continue with install: existing resource conflict: kind: ResourceQuota, namespace: cilium, name: cilium-resource-quota

I have been able to pass the K8sUpdates test with this commit manually on GKE against the master branch.

[gandro]

test-me-please

[gandro]

GKE failed, maybe due to the Google outage. The symptom is tests failing with Error: rendered manifests contain a resource that already exists. Unable to continue with install: existing resource conflict: kind: Secret, namespace: cilium, name: hubble-server-certs, but I believe that's due to some clean-up routine getting sigkilled, as this would have had to occur previously. Restarting GKE.

https://jenkins.cilium.io/job/Cilium-PR-K8s-GKE/3661/

[gandro]

retest-gke

[aanm]

Changes LGTM but I'm wondering about all other options

[gandro]

Changes LGTM but I'm wondering about all other options

What other options? I did quickly skim over the other options in the map I modified, none of them have changed between 1.8 and 1.9. Did you have anything specific in mind?

Edit: Discussed offline. This was about the other values in the map, which were unaffected by the 1.9 Helm change.

[joestringer]

Looks like this was needed on the v1.9 branch, but we should be able to remove it on master when we bump the upgrade test to upgrade from v1.9 to master. (Along with convertOptionsToLegacyOptions() which is the generic code that handles this type of change).

[gandro]

Looks like this was needed on the v1.9 branch, but we should be able to remove it on master when we bump the upgrade test to upgrade from v1.9 to master. (Along with convertOptionsToLegacyOptions() which is the generic code that handles this type of change).

Thanks for pointing out convertOptionsToLegacyOptions(), I was not aware of that!

I'm not sure I fully understand your comment however: The preflight check (which on master is currently deployed with the 1.9.90 chart) does also need agent instead of agent.enabled.

Is your comment solely referring to the if-logic? In that case yes, arguably, we don't need the if logic on master, assuming InstallAndValidateCiliumUpgrades is never called with newHelmChartVersion != helpers.CiliumLatestHelmChartVersion. I was not sure this assumption always holds, which is why I added logic.