Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Remove Jenkins Prechecks #14400

Merged
merged 1 commit into from
Dec 16, 2020
Merged

Conversation

nathanjsweet
Copy link
Member

Now that we have a github workflow that does the
static language prechecks on both pull-requests and
the master branch we no longer need to run these checks
inside Jenkins.

Removed unnecessarily redundant static analysis in CI to streamline CI running times.

@nathanjsweet nathanjsweet added area/CI-improvement Topic or proposal to improve the Continuous Integration workflow release-note/ci This PR makes changes to the CI. labels Dec 14, 2020
@nathanjsweet nathanjsweet requested review from a team as code owners December 14, 2020 17:50
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Dec 14, 2020
@nathanjsweet
Copy link
Member Author

test-me-please

Copy link
Member

@christarazi christarazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Never knew we had this in Jenkins.

Copy link
Member

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One remark regarding make ci-precheck, otherwise LGTM.

test/docker-compose.yml Show resolved Hide resolved
Copy link
Member

@nebril nebril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional removals suggested by @pchaigno and @tklauser would be perfect.

Now that we have a github workflow that does the
static language prechecks on both pull-requests and
the master branch we no longer need to run these checks
inside Jenkins. Other pre-checks that are no longer
in use have been removed.

Signed-off-by: Nate Sweet <nathanjsweet@pm.me>
@nathanjsweet nathanjsweet force-pushed the pr/nathanjsweet/remove-jenkins-precheck branch from c644f44 to de08617 Compare December 15, 2020 17:14
@nathanjsweet
Copy link
Member Author

test-me-please

tklauser added a commit to cilium/packer-ci-build that referenced this pull request Dec 15, 2020
cilium/cilium#14400 removed the usage of docker-compose from Cilium CI.
Thus, drop it from the dev VM image as well. Also drop
quay.io/coreos/etcd:v3.2.17 from the list of pre-pulled images. Its only
usage in CI was removed by the same PR as well.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Dec 15, 2020
@nebril nebril merged commit eac57c0 into master Dec 16, 2020
@nebril nebril deleted the pr/nathanjsweet/remove-jenkins-precheck branch December 16, 2020 09:49
tklauser added a commit to cilium/packer-ci-build that referenced this pull request Dec 16, 2020
cilium/cilium#14400 removed the usage of docker-compose from Cilium CI.
Thus, drop it from the dev VM image as well. Also drop
quay.io/coreos/etcd:v3.2.17 from the list of pre-pulled images. Its only
usage in CI was removed by the same PR as well.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
tklauser added a commit to cilium/packer-ci-build that referenced this pull request Jan 15, 2021
cilium/cilium#14400 removed the usage of docker-compose from Cilium CI.
Thus, drop it from the dev VM image as well. Also drop
quay.io/coreos/etcd:v3.2.17 from the list of pre-pulled images. Its only
usage in CI was removed by the same PR as well.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
@joestringer joestringer moved this from In progress to Done in 1.10.0 Feb 12, 2021
@joestringer joestringer moved this from In progress to Done in 1.10.0 Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI-improvement Topic or proposal to improve the Continuous Integration workflow ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants