-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Remove Jenkins Prechecks #14400
ci: Remove Jenkins Prechecks #14400
Conversation
test-me-please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Never knew we had this in Jenkins.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One remark regarding make ci-precheck
, otherwise LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that we have a github workflow that does the static language prechecks on both pull-requests and the master branch we no longer need to run these checks inside Jenkins. Other pre-checks that are no longer in use have been removed. Signed-off-by: Nate Sweet <nathanjsweet@pm.me>
c644f44
to
de08617
Compare
test-me-please |
cilium/cilium#14400 removed the usage of docker-compose from Cilium CI. Thus, drop it from the dev VM image as well. Also drop quay.io/coreos/etcd:v3.2.17 from the list of pre-pulled images. Its only usage in CI was removed by the same PR as well. Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
cilium/cilium#14400 removed the usage of docker-compose from Cilium CI. Thus, drop it from the dev VM image as well. Also drop quay.io/coreos/etcd:v3.2.17 from the list of pre-pulled images. Its only usage in CI was removed by the same PR as well. Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
cilium/cilium#14400 removed the usage of docker-compose from Cilium CI. Thus, drop it from the dev VM image as well. Also drop quay.io/coreos/etcd:v3.2.17 from the list of pre-pulled images. Its only usage in CI was removed by the same PR as well. Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Now that we have a github workflow that does the
static language prechecks on both pull-requests and
the master branch we no longer need to run these checks
inside Jenkins.