hubble/parser/threefour: ignore gopacket errors on unsupported layers #14418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Errors returned by gopacket.DecodingLayerParser.DecodeLayers are already ignored by the Hubble L3/L4 parser. However, this is currently achieved by matching the error message of the returned err. Avoid this by setting gopacket.DecodingLayerParser.IgnoreUnsupported in threefour.New such that gopacket.DecodingLayerParser.DecodeLayers returns a nil error when it encounters a layer it doesn't have a parser for. Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
tklauser
added
release-note/misc
|
test-me-please |
rolinh
approved these changes
Dec 15, 2020
|
retest-runtime failed on known flake #14125 https://jenkins.cilium.io/job/Cilium-PR-Runtime-4.9/3049/ |
|
retest-gke Scaling cluster failed https://jenkins.cilium.io/job/Cilium-PR-K8s-GKE/3686/ |
twpayne
approved these changes
Dec 16, 2020
tklauser
added
the
ready-to-merge
|
Got two reviews from @cilium/hubble (@kaworu is OOO today) and CI passed. Marked as ready to merge. |
|
retest-gke |
glibsm
reviewed
Dec 16, 2020
maintainer-s-little-helper
bot
removed
the
ready-to-merge
It shouldn't. The behavior is expected to be the same, this only changes the way we treat unsupported layers from having them ignored in |
tklauser
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Errors returned by
gopacket.DecodingLayerParser.DecodeLayersare alreadyignored by the Hubble L3/L4 parser. However, this is currently achieved
by matching the error message of the returned
err. Avoid this by settinggopacket.DecodingLayerParser.IgnoreUnsupportedinthreefour.Newsuchthat
gopacket.DecodingLayerParser.DecodeLayersreturns a nil error whenit encounters a layer it doesn't have a parser for.