Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

datapath: Remove IPV{4,6}_NODEPORT #14431

Merged
merged 1 commit into from
Dec 21, 2020
Merged

datapath: Remove IPV{4,6}_NODEPORT #14431

merged 1 commit into from
Dec 21, 2020

Conversation

brb
Copy link
Member

@brb brb commented Dec 16, 2020

After introducing IPV{4,6}_MASQUERADE, the former is no longer in use.

For the case when a LB request has to be forwarded to a destination
node, we use IPV{4,6}_DIRECT_ROUTING. For SNAT from endpoint to outside
we use IPV{4,6}_MASQUERADE.

Fix #14273

@brb brb added pending-review sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. labels Dec 16, 2020
@brb brb requested a review from a team December 16, 2020 15:48
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Dec 16, 2020
@brb brb requested a review from jrfastab December 16, 2020 15:48
@brb brb force-pushed the pr/brb/rm-ipv46-nodeport branch 2 times, most recently from 5f30ee9 to 15d3acd Compare December 16, 2020 15:54
@brb brb marked this pull request as draft December 16, 2020 16:30
@brb brb force-pushed the pr/brb/rm-ipv46-nodeport branch 3 times, most recently from 873b103 to 1000d93 Compare December 17, 2020 10:43
@brb
datapath: Remove IPV{4,6}_NODEPORT
1000d93 
After introducing IPV{4,6}_MASQUERADE, the former is no longer in use.

For the case when a LB request has to be forwarded to a destination
node, we use IPV{4,6}_DIRECT_ROUTING. For SNAT from endpoint to outside
we use IPV{4,6}_MASQUERADE.

Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb
Copy link
Member Author

brb commented Dec 17, 2020

checkpatch.pl is failing with a false positive:

WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#74: FILE: bpf/lib/nodeport.h:914:
+       if (DIRECT_ROUTING_DEV_IFINDEX == NATIVE_DEV_IFINDEX &&

NATIVE_DEV_IFINDEX is set while loading via the templating.

@brb
Copy link
Member Author

brb commented Dec 17, 2020

test-me-please

@brb brb marked this pull request as ready for review December 17, 2020 14:08
@brb brb requested a review from borkmann December 17, 2020 14:08
@brb brb merged commit 129aa12 into master Dec 21, 2020
@brb brb deleted the pr/brb/rm-ipv46-nodeport branch December 21, 2020 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@borkmann borkmann borkmann approved these changes

@jrfastab jrfastab Awaiting requested review from jrfastab

Assignees

@borkmann borkmann

@jrfastab jrfastab

Labels
kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
No open projects
1.10.0
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

datapath: Remove IPV{4,6}_NODEPORT macros
3 participants
@brb @borkmann @jrfastab