Extend K8sVerifier to maximize program sizes on 4.19 and net-next kernels #14451
Commits on Jan 22, 2021
-
bpf: Compile test with tunneling disabled
On the datapath side, we often rely on ENCAP_IFINDEX to check if tunneling mode is enabled (in which case the macro is defined). This macro is defined in our test header files and therefore never compile tested. This commit removes it from the test header files and adds it to the Makefile targets to be compile tested. This is also needed to be able to load the generated bpf_xdp programs. If the ENCAP_IFINDEX macro is always defined, then bpf_xdp programs are compiled with calls to the ctx_{get,set}_tunnel_key BPF helpers, which don't exist for the XDP hook. Signed-off-by: Paul Chaignon <paul@cilium.io> -
bpf: Refactor MAX_*_OPTIONS and enable more options
The NAT46 change in node_config.h is required to define CONNTRACK is ENABLE_NAT46 is defined. This wasn't previously required because ENABLE_NAT46 was only defined for bpf_xxx files that have CONNTRACK defined in their own header file (e.g., ep_config.h). Signed-off-by: Paul Chaignon <paul@cilium.io>
-
bpf: Maximize compiled program size for each kernel
The make target for the BPF programs takes a KERNEL environment variable. This variable is used to try and maximize the program size for each kernel, by enabling as many features as possible. This new environment variable is also used in the existing K8sVerifier test. Signed-off-by: Paul Chaignon <paul@cilium.io>
-
bpf: Fix compile-tested macros used in is_defined
In the datapath, we have two ways to check if a macro is defined: the usual defined()/#ifdef and is_defined(). The later is often used in C predicates or in tail call conditions. It expects the macro to be defined with a value, typically #define ENABLE_FEATURE_X 1. Without this non-zero value, is_defined(ENABLE_FEATURE_X) returns false. The list of macros that are used in is_defined can be extracted with the following command: git grep -hoP "(?<=is_defined\()[_A-Z0-9]+" bpf/ | sort | uniq Nevertheless, in this commit, to prevent mistakes in future addition, I've added a value to all macros. This is automatically achieved by replacing ':' by '=1 ' instead of just a space. It however requires that all macros be followed by ':'. Signed-off-by: Paul Chaignon <paul@cilium.io> -
bpf: Compile test object files with same mcpu as cilium-agent
When compiling our datapath (base and endpoint's), cilium-agent selects mcpu=v1 or v2 depending on the kernel version. Up until now, the object files generated for test-verifier.sh had mcpu=probe. This commit changes it to match what cilium-agent does. Signed-off-by: Paul Chaignon <paul@cilium.io>
-
bpf: Define ENABLE_HOST_SERVICES_FULL in verifier tests
If ENABLE_HOST_SERVICES_FULL is undefined, additional code is compiled in our datapath, leading us to run into known complexity issue #14234. We only need to work around this issue on the latest kernels. Signed-off-by: Paul Chaignon <paul@cilium.io>
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.