v1.9 backport: node: Remove check whether nextHop is in same L2 #14453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brb
added
kind/backports
|
test-backport-1.9 |
aanm
approved these changes
Dec 21, 2020
aanm
requested changes
Dec 21, 2020
brb
force-pushed
the
pr/brb/v1.9-rm-arping-l2-addr-check
branch
from
7595d5d
to
fac4b87
Compare
aanm
requested changes
Dec 22, 2020
It was reported that on a GKE cluster the neigh handling logged the
following error:
level=error msg="IP is not L2 reachable" error="iface: 'eth0' can't
reach ip: '10.164.0.1'" interface=eth0 ipAddr=10.164.0.1
subsys=linux-datapath
The "ip route" and "ip addr" had the following relevant entries:
default via 10.164.0.1 dev eth0 proto dhcp metric 1024
10.164.0.1 dev eth0 proto dhcp scope link metric 1024
eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1460 qdisc mq state UP
group default qlen 1000 link/ether 42:01:0a:a4:00:4f brd ff:ff:ff:ff:ff:ff
inet 10.164.0.79/32 scope global dynamic eth0
As we can see, eth0 had IP addr assigned from /32 subnet which made the
check for nexthop in the same L2 to fail regardless of the "10.164.0.1
dev eth0" route.
This commit removes the check, as nexthop is guaranteed to be L2-reachable
by the Linux kernel routing system.
Reported-by: Joe Stringer <joe@cilium.io>
Reported-by: Paul Chaignon <paul@cilium.io>
Signed-off-by: Martynas Pumputis <m@lambda.lt>
brb
force-pushed
the
pr/brb/v1.9-rm-arping-l2-addr-check
branch
from
fac4b87
to
a2dd505
Compare
The updated version contains the following change:
arping: Make PingOverIface* to accept source IP addr
Instead of trying to derive the src IP with FindIPInNetworkFromIface(),
accept src IP addr as a param. The latter function is broken for the
case when the iface has IP addr assigned from the /32 subnet and there
exists an route to the gw via the iface (GKE).
Also, use the source IP addr for arping from the nexthop route.
Signed-off-by: Martynas Pumputis <m@lambda.lt>
|
test-backport-1.9 |
aanm
approved these changes
Jan 4, 2021
|
retest-net-next |
|
retest-runtime |
|
CI net-next failed with: |
|
retest-net-next |
brb
added
the
ready-to-merge
pchaigno
approved these changes
Jan 6, 2021
There was a problem hiding this comment.
The two backported commits are missing references to the upstream commits. Those references are automatically added when using our cherry-pick script.
@brb If you want to fix that, I can merge without rerunning the whole tests after the update. Otherwise, I'll merge before end of day.
There are no upstream commits. The commits in this PR are only for v1.9. |
Oh, I missed that the "upstream" PR was closed and I had completely forgot our discussion. Merging both backport PRs 🚢 |
aanm
added
the
release-note/bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #14354 for v1.9.