service: Restore Maglev table when M changes #14469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
|
test-me-please |
christarazi
reviewed
Dec 21, 2020
brb
force-pushed
the
pr/brb/recalc-maglev-after-rm-map
branch
from
56ed2c8
to
090b024
Compare
When running in the lb-only mode, there is no connectivity to kube-apiserver, and UpsertService() can be only invoked by the Cilium API calls. When cilium-agent restarts, it might recreate the Maglev BPF map if it detects that the M param might have changed. The recreation removes the lookup entries from the map leaving the map empty. As there is no way to resync (with kube-apiserver) after the restart, we need to fix this by recalculating the Maglev tables during the restoration of services from the LB BPF maps. Reported-by: Han Zhou <hzhou8@ebay.com> Signed-off-by: Martynas Pumputis <m@lambda.lt>
|
retest-net-next |
brb
added
the
release-note/bug
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
aanm
requested changes
Jan 4, 2021
aanm
approved these changes
Jan 4, 2021
christarazi
approved these changes
Jan 4, 2021
|
Previously all tests have passed. After pushing small changes, I ran only net-next which passed. The PR is good to merge. |
brb
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running in the lb-only mode, there is no connectivity to
kube-apiserver, and UpsertService() can be only invoked by the Cilium
API calls.
When cilium-agent restarts, it might recreate the Maglev BPF map if it
detects that the M param might have changed. The recreation removes the
lookup entries from the map leaving the map empty.
As there is no way to resync (with kube-apiserver) after the restart, we
need to fix this by recalculating the Maglev tables during the
restoration of services from the LB BPF maps.
Reported-by: Han Zhou hzhou8@ebay.com