Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add iptables masquerading without random-fully test #14476

Merged

Conversation

jibi
Copy link
Member

@jibi jibi commented Dec 22, 2020

As suggested in the ticket, let's add a test for iptables masqueranding
without the random-fully option. This should tell us if the
"K8sDatapathConfig Encapsulation Check iptables masquerading with
random-fully" test is failing due to the random-fully option or not.

Related-to: #13773

As suggested in the ticket, let's add a test for iptables masqueranding
_without_ the random-fully option. This should tell us if the
"K8sDatapathConfig Encapsulation Check iptables masquerading with
random-fully" test is failing due to the random-fully option or not.

Related-to: #13773

Signed-off-by: Gilberto Bertin <gilberto@isovalent.com>
@jibi jibi requested review from nebril and a team December 22, 2020 14:21
@jibi jibi requested a review from a team as a code owner December 22, 2020 14:21
@jibi jibi requested a review from jrfastab December 22, 2020 14:21
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Dec 22, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Dec 22, 2020
@jibi jibi added the release-note/ci This PR makes changes to the CI. label Dec 22, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Dec 22, 2020
@jibi
Copy link
Member Author

jibi commented Dec 22, 2020

test-me-please

Copy link
Member

@christarazi christarazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question about potentially optimizing the pipeline, otherwise LGTM.

test/k8sT/DatapathConfiguration.go Show resolved Hide resolved
@aanm aanm merged commit b942010 into master Dec 28, 2020
@aanm aanm deleted the pr/jibi/add-iptables-masquerading-without-random-fully-test branch December 28, 2020 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/ci This PR makes changes to the CI.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants