Extend cilium-operator binary to be used as command line tool #14484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
fristonio
added
the
release-note/minor
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
fristonio
force-pushed
the
pr/fristonio/operator-api-and-cmd
branch
2 times, most recently
from
8454d52
to
f68651a
Compare
|
test-me-please |
|
retest-gke |
sayboras
reviewed
Dec 26, 2020
fristonio
force-pushed
the
pr/fristonio/operator-api-and-cmd
branch
2 times, most recently
from
4f4e858
to
181b76d
Compare
kaworu
approved these changes
Jan 5, 2021
There was a problem hiding this comment.
Overall LGTM. I think CODEOWNERS should be updated to take into account the new /api/v1/operator directory:
diff --git a/CODEOWNERS b/CODEOWNERS
index bdbe06c83..29d6a492e 100644
--- a/CODEOWNERS
+++ b/CODEOWNERS
@@ -35,6 +35,7 @@
/api/ @cilium/api
/api/v1/flow/ @cilium/api @cilium/hubble
/api/v1/observer/ @cilium/api @cilium/hubble
+/api/v1/operator/ @cilium/api @cilium/operator
/api/v1/peer/ @cilium/api @cilium/hubble
/bpf/ @cilium/bpf
Makefile* @cilium/build
|
test-me-please |
aanm
requested changes
Jan 5, 2021
fristonio
force-pushed
the
pr/fristonio/operator-api-and-cmd
branch
from
e47d1f5
to
b738a1d
Compare
Signed-off-by: Deepesh Pathak <deepshpathak@gmail.com>
Signed-off-by: Deepesh Pathak <deepshpathak@gmail.com>
Signed-off-by: Deepesh Pathak <deepshpathak@gmail.com>
* By default the open-api spec contains the /v1 basepath. This commit adds a separate handler for /healthz requests outside of the default basepath. This is done using HTTP server mux where the index handler is the default open-api router and `/healthz` requests are handled by a new handler. Signed-off-by: Deepesh Pathak <deepshpathak@gmail.com>
Signed-off-by: Deepesh Pathak <deepshpathak@gmail.com>
Signed-off-by: Deepesh Pathak <deepshpathak@gmail.com>
fristonio
force-pushed
the
pr/fristonio/operator-api-and-cmd
branch
from
b738a1d
to
e40cf73
Compare
|
test-me-please |
aanm
approved these changes
Jan 6, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PullRequest aims at extending the
cilium-operatorbinary to be used as a command-line tool. There are two reworks associated with this PR.cilium-operatorto useopenapiconfig as apiserver implementation similar to what we have for Cilium andcilium-health.cilium-operatorto list metrics from a running cilium-operator instance apiserver.Fixes #13132