Convert AWS API calls to use paginators #14491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ungureanuvladvictor
added
pending-review
area/eni
|
test-me-please |
ungureanuvladvictor
force-pushed
the
vladu/aws-paginators
branch
from
38f3942
to
057ec26
Compare
|
test-me-please |
ungureanuvladvictor
force-pushed
the
vladu/aws-paginators
branch
from
057ec26
to
44aefa9
Compare
|
test-me-please updated #12511 (comment) with the failure in netnext. |
aanm
approved these changes
Dec 28, 2020
|
retest-net-next |
christarazi
approved these changes
Dec 28, 2020
Some of the AWS API calls that we do are not doing correct pagination. This means that we return partial output to the calling functions. Those ones are (from the ec2 internal package): - `describeVpcs` - `describeSubnets` - `describeSecurityGroups` The ones that implement manually pagination are: - `describeNetworkInterfaces` - `GetInstanceTypes` Signed-off-by: Vlad Ungureanu <vladu@palantir.com>
ungureanuvladvictor
force-pushed
the
vladu/aws-paginators
branch
from
44aefa9
to
fdb046d
Compare
|
test-me-please @christarazi -- updated the commit msg. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the AWS API calls that we do are not doing correct pagination. This means that we return partial output to the calling functions. Those ones are (from the ec2 internal package):
describeVpcsdescribeSubnetsdescribeSecurityGroupsThe ones that implement manually pagination are:
describeNetworkInterfacesGetInstanceTypesOverall it might not be important to implement pagination for all EC2 API calls but is good to standardize on it. Happy to revisit this if the reviewers think this is complicating things too much.
Signed-off-by: Vlad Ungureanu vladu@palantir.com