add_vagrant_box.sh: Fix incorrect vagrant box updates #14527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running add_vagrant_box.sh with aria2c and a package.box file
already present in the destination directory, the script ends up adding
the existing .box file instead of the downloaded one. This can also
happen if several VM images are downloaded during the same run of
add_vagrant_box.sh.
01/05 17:00:15 [NOTICE] Download complete: /home/qmo/tmp/package.3.box
Download Results:
gid |stat|avg speed |path/URI
======+====+===========+=======================================================
138a73|OK | 4.5MiB/s|/home/qmo/tmp/package.3.box
Status Legend:
(OK):download completed.
==> box: Box file was not detected as metadata. Adding it directly...
==> box: Adding box 'cilium/ubuntu-4-19' (v0) for provider:
box: Unpacking necessary files from: file:///home/qmo/tmp/package.box
We can easily fix this by instructing aria2c to overwrite any existing
package.box file.
Suggested-by: Quentin Monnet <quentin@isovalent.com>
Signed-off-by: Paul Chaignon <paul@cilium.io>
Suggested-by: Quentin Monnet <quentin@isovalent.com> Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
added
the
release-note/misc
joestringer
approved these changes
Jan 5, 2021
aditighag
pushed a commit
that referenced
this pull request
Jan 7, 2021
We prevented aria2c to rename the downloaded "package.box" at one location, to avoid unpacking the wrong file in case there was already a package.box in the download directory and the new one has been renamed. But we did so for one of the two possible aria2c invocations in the script. Let's make sure we do it everytime aria2c is used. And let's suppress summaries displayed at regular intervals by aria2c, to avoid cluttering console output. Fixes: #14527 Fixes: f763fef ("add_vagrant_box.sh: Fix bug causing download of incorrect VM images") Signed-off-by: Quentin Monnet <quentin@isovalent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
add_vagrant_box.shwith aria2c and apackage.boxfile already present in the destination directory, the script ends up adding the existing.boxfile instead of the downloaded one. This can also happen if several VM images are downloaded during the same run ofadd_vagrant_box.sh.We can easily fix this by instructing aria2c to overwrite any existing
package.boxfile.