-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add cilium-operator technical overview documentation #14530
Conversation
1cde926
to
89e0ab9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
89e0ab9
to
9c0d5f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Pointed out mostly minor things for consistency and clarity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for the doc!
Please find a few nits inline. Additionally,
- Please make sure to be consistent and use either regular or title case for all titles.
- Should this document be moved elsewhere than the root of
Documentation
? MaybeDocumentation/concepts/
at least?
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
e2c00ee
to
db6de66
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this PR is waiting for my approval to be merged, but I would still appreciate to have
- Consistent title case on titles (+ consistency on expansion, or not, of “Garbage Collection”),
- Consistent case on “KVStore”.
Would it make sense to add a directory for documentation oriented towards developers? We probably don't want to move the existing documents bpf
, hubble
etc.), but that would avoid adding too many new documents to the root of the Documentation/ as this section grows?
Signed-off-by: Deepesh Pathak <deepshpathak@gmail.com>
552cd67
to
055ca27
Compare
@qmonnet I have updated the docs to have a more consistent format for the specifics you mentioned. Let me know if I missed something.
Yeah, I think it makes sense to do this. I don't have a concrete option for this though, we can possibly have a section inside |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes!
we can possibly have a section inside
For Developers
calledInternals
and put hubble and these operator docs under it?
Yes, this sounds like a good option to me, let's do this please.
Signed-off-by: Deepesh Pathak <deepshpathak@gmail.com>
@qmonnet I have added a section for Cilium components specific internals under |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks good, I'm just wondering if we're OK with moving the Hubble doc (I thought you meant reorganising the TOC, I didn't think you would rename the file and change the URL). I think it's fine, because if people want stable links, they should use a version number in the URL, but I'm not entirely sure of our policy on that. I'd appreciate another look from @joestringer, for example.
👍 I'm okay with this. We can also set up redirects so that the old link leads to the new location. |
Ok let's go with this version then 👍 |
It's configured in the hosting platform (https://readthedocs.org/dashboard/cilium/redirects/). I have access, I just need source and destination paths and I can add it. I'm not exactly sure whether it unconditionally redirects or whether it only redirects in the case of direct navigation hitting a 404 so we may need to do a little investigation together there. |
Hey @joestringer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Hubble/K8s codeowners are only pulled in because the files are touched, but the validation is more related to docs codeowners. Good to merge.
Will just close/reopen to kick GH workflows to double-check that docs tests pass before merge. |
I set up the redirect, looks like it's working correctly. 👍 |
Thanks a lot @joestringer |
Fixes #13298