pkg/sysctl: Sanitize parameter names #14533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twpayne
added
the
release-note/misc
twpayne
force-pushed
the
pr/twpayne/sanitize-sysctl-params
branch
from
de4e8af
to
2f1a769
Compare
aanm
approved these changes
Jan 6, 2021
joestringer
approved these changes
Jan 6, 2021
twpayne
force-pushed
the
pr/twpayne/sanitize-sysctl-params
branch
from
2f1a769
to
e94dbcf
Compare
|
test-me-please |
|
retest-4.9 |
1 similar comment
|
retest-4.9 |
twpayne
force-pushed
the
pr/twpayne/sanitize-sysctl-params
branch
from
e94dbcf
to
1c8f0bd
Compare
|
test-me-please |
|
test-gke |
twpayne
added
the
dont-merge/preview-only
twpayne
force-pushed
the
pr/twpayne/sanitize-sysctl-params
branch
from
bf87d77
to
9ac0c6a
Compare
twpayne
removed
the
dont-merge/preview-only
twpayne
force-pushed
the
pr/twpayne/sanitize-sysctl-params
branch
from
9ac0c6a
to
29b6ede
Compare
|
test-me-please |
|
The Travis CI failure is #11990. |
|
retest-gke |
aanm
reviewed
Jan 14, 2021
tklauser
approved these changes
Jan 15, 2021
twpayne
force-pushed
the
pr/twpayne/sanitize-sysctl-params
branch
from
c5f0f00
to
72a7f13
Compare
|
test-me-please |
|
#15459 on gke. |
|
@brb What do you make of the wireguard flake in net-next? |
vadorovsky
approved these changes
Mar 29, 2021
|
@nathanjsweet Thanks for pinging. Opened #15507 which might resolve it. |
twpayne
force-pushed
the
pr/twpayne/sanitize-sysctl-params
branch
from
72a7f13
to
2092798
Compare
|
test-me-please |
|
@twpayne sorry, can you rebase against master and trigger the tests just to be safe? |
twpayne
force-pushed
the
pr/twpayne/sanitize-sysctl-params
branch
from
2092798
to
e209d3e
Compare
|
test-me-please |
|
Cilium-PR-K8s-1.20-kernel-4.9 failure seems to be known flake #13011. Cilium-PR-K8s-1.13-net-next failure seems to be known flake #12511. |
|
test-1.13-netnext |
|
test-1.20-4.9 |
This avoids a security warning raised by CodeQL. In theory, before this
PR, carefully formed parameter names could read arbitrary files in the
filesystem, e.g.
sysctl.Read("../../etc/passwd")
In practice, this is was likely unexploitable as '.'s were replaced with
'/'s, making path traversal tricky.
The updated code verifies that parameter names are valid.
Signed-off-by: Tom Payne <tom@isovalent.com>
Signed-off-by: Tom Payne <tom@isovalent.com>
Signed-off-by: Tom Payne <tom@isovalent.com>
twpayne
force-pushed
the
pr/twpayne/sanitize-sysctl-params
branch
from
e209d3e
to
283b9d9
Compare
|
test-me-please |
1 similar comment
|
test-me-please |
|
Not clear if https://jenkins.cilium.io/job/Cilium-PR-K8s-GKE/4934/testReport/junit/Suite-k8s-1/17/K8sDatapathConfig_Etcd_Check_connectivity/ is a flake. Let's see: test-gke |
|
Provisioning issue: test-runtime |
pchaigno
added
the
ready-to-merge
This was referenced Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR avoids a warning issued by CodeQL where it identified "Uncontrolled data used in path expression". Refs #14514.