Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/helpers: Allow ssh.InsecureIgnoreHostKey in test code #14535

Merged
merged 1 commit into from
Jan 6, 2021
Merged

test/helpers: Allow ssh.InsecureIgnoreHostKey in test code #14535

merged 1 commit into from
Jan 6, 2021

Conversation

twpayne
Copy link
Contributor

@twpayne twpayne commented Jan 6, 2021

This suppresses a warning from CodeQL.

Refs #14514.

Signed-off-by: Tom Payne tom@isovalent.com

@twpayne
test/helpers: Allow ssh.InsecureIgnoreHostKey in test code
5317156 
This suppresses a warning from CodeQL.

Signed-off-by: Tom Payne <tom@isovalent.com>
@twpayne twpayne added the release-note/misc This PR makes changes that have no direct user impact. label Jan 6, 2021
@twpayne twpayne requested a review from a team as a code owner January 6, 2021 13:31
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Jan 6, 2021
pchaigno
pchaigno approved these changes Jan 6, 2021
View reviewed changes
Copy link
Member

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth adding these sorts of annotations to avoid CodeQL warnings directly to #14514 in order to reduce the noise?

@pchaigno pchaigno added kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels Jan 6, 2021
@pchaigno
Copy link
Member

pchaigno commented Jan 6, 2021

This pull request includes only new code comments, so no need to run the e2e tests. Merging.

@pchaigno pchaigno merged commit 3e886b5 into master Jan 6, 2021
@pchaigno pchaigno deleted the pr/twpayne/ssh-helpers-codeql branch January 6, 2021 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchaigno pchaigno pchaigno approved these changes

@michi-covalent michi-covalent Awaiting requested review from michi-covalent

Assignees

@michi-covalent michi-covalent

Labels
kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.10.0
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@twpayne @pchaigno @michi-covalent