pkg/rate: Make parsing of positive values more strict #14536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twpayne
added
the
release-note/misc
aanm
approved these changes
Jan 6, 2021
pchaigno
approved these changes
Jan 6, 2021
This fixes issues identified by CodeQL where strings were parsed as unsigned integers and then converted to integers without a bounds check. Signed-off-by: Tom Payne <tom@isovalent.com>
twpayne
force-pushed
the
pr/twpayne/rate-int-conversion
branch
from
03c0da0
to
dc2e43b
Compare
|
test-me-please |
|
retest-net-next |
|
test-gke |
|
The Cilium-Ginkgo-GKE check is currently failing with messages like: This seems unrelated to the changes in this PR. |
|
retest-gke |
1 similar comment
|
retest-gke |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issues identified by CodeQL where strings were parsed as
unsigned integers and then converted to integers without a bounds check.
Refs #14514
Signed-off-by: Tom Payne tom@isovalent.com