-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helm: Add option to enable k8s events handover. #14555
Conversation
@reviewers not sure about the release note. |
ee7a7cc
to
6268530
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Release note can be release-note/misc
and you can word it to users as:
Allow enable-k8s-event-handover to be configured via Helm to control CNP Node status updates
or something like that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM, just a minor nit. 💯
6268530
to
53bf329
Compare
53bf329
to
de60153
Compare
Currently, there is no way to configure the operator to handle the CNP status updates using Helm. This PR adds the missing field in the Cilium's ConfigMap needed when using the Helm side to allow CNP status updates: `enable-k8s-event-handover` Fixes: cilium#14547 Signed-off-by: Youssef Azrak <yazrak.tech@gmail.com>
de60153
to
c6ffd06
Compare
test-me-please |
Currently, there is no way to configure the operator to handle the CNP
status updates using Helm.
This PR adds the missing field in the Cilium's ConfigMap needed when
using the Helm side to allow CNP status updates:
enable-k8s-event-handover
Fixes: #14547
Signed-off-by: Youssef Azrak yazrak.tech@gmail.com