Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm: Add option to enable k8s events handover. #14555

Merged
merged 1 commit into from
Jan 14, 2021

Conversation

youssefazrak
Copy link
Contributor

@youssefazrak youssefazrak commented Jan 7, 2021

Currently, there is no way to configure the operator to handle the CNP
status updates using Helm.

This PR adds the missing field in the Cilium's ConfigMap needed when
using the Helm side to allow CNP status updates: enable-k8s-event-handover

Fixes: #14547

Signed-off-by: Youssef Azrak yazrak.tech@gmail.com

Helm: Allow enable-k8s-event-handover to be configured via Helm to control CNP Node status updates

@youssefazrak youssefazrak requested review from a team as code owners January 7, 2021 19:04
@youssefazrak youssefazrak requested review from a team, qmonnet and kaworu January 7, 2021 19:04
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 7, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Jan 7, 2021
@youssefazrak youssefazrak requested a review from brb January 7, 2021 19:04
@youssefazrak youssefazrak changed the title Helm: Add option to enable k8s events handover. WIP - Helm: Add option to enable k8s events handover. Jan 7, 2021
@youssefazrak
Copy link
Contributor Author

@reviewers not sure about the release note.

Copy link
Member

@christarazi christarazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Release note can be release-note/misc and you can word it to users as:

Allow enable-k8s-event-handover to be configured via Helm to control CNP Node status updates

or something like that.

Copy link
Member

@fristonio fristonio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM, just a minor nit. 💯

install/kubernetes/cilium/values.yaml Show resolved Hide resolved
@youssefazrak youssefazrak changed the title WIP - Helm: Add option to enable k8s events handover. Helm: Add option to enable k8s events handover. Jan 7, 2021
@fristonio fristonio added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Jan 7, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 7, 2021
@fristonio fristonio added the area/helm Impacts helm charts and user deployment experience label Jan 7, 2021
Currently, there is no way to configure the operator to handle the CNP
status updates using Helm.

This PR adds the missing field in the Cilium's ConfigMap needed when
using the Helm side to allow CNP status updates: `enable-k8s-event-handover`

Fixes: cilium#14547

Signed-off-by: Youssef Azrak <yazrak.tech@gmail.com>
@qmonnet qmonnet removed their assignment Jan 8, 2021
@fristonio fristonio added release-note/misc This PR makes changes that have no direct user impact. and removed release-note/minor This PR changes functionality that users may find relevant to operating Cilium. labels Jan 9, 2021
@aanm
Copy link
Member

aanm commented Jan 11, 2021

test-me-please

@aanm aanm merged commit 6191557 into cilium:master Jan 14, 2021
@youssefazrak youssefazrak deleted the cnp_events_handover branch April 9, 2021 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm Impacts helm charts and user deployment experience release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Add helm option to enable k8s events handover
7 participants