Vagrantfile: Add support for SHARE_PARENT=2 #14559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for value "2" for "SHARE_PARENT" environment variable, which causes the parent of the parent of the current directory to be shared with the Dev VM. This is useful to share all the github.com repositories in the developer's directory tree with the dev VM without using "USER_MOUNTS". This also fixes the NFS mount error on macOS when one exported NFS directory is within another. This would happen if the cilium repo is in the same tree that would be shared with USER_MOUNTS. Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
jrajahalme
added
area/CI
|
test-me-please |
pchaigno
approved these changes
Jan 8, 2021
| if ENV["SHARE_PARENT"] == "2" then | ||
| cilium_dir = '../..' | ||
| cilium_path = '/home/vagrant/go/src/github.com' | ||
| elsif ENV["SHARE_PARENT"] then |
There was a problem hiding this comment.
Might be worth checking for == "1" here, in case some contributors see the SHARE_PARENT=2 and try to disable by explicitely passing SHARE_PARENT=0.
|
retest-gke |
1 similar comment
|
retest-gke |
christarazi
approved these changes
Jan 8, 2021
|
We don't use the Vagrantfiles for GKE, so I don't think we need to wait for that CI pipeline. Marking as ready to merge. |
pchaigno
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for value "2" for "SHARE_PARENT" environment variable,
which causes the parent of the parent of the current directory to be
shared with the Dev VM. This is useful to share all the github.com
repositories in the developer's directory tree with the dev VM without
using "USER_MOUNTS".
This also fixes the NFS mount error on macOS when one exported NFS
directory is within another. This would happen if the cilium repo is
in the same tree that would be shared with USER_MOUNTS.
Signed-off-by: Jarno Rajahalme jarno@covalent.io