envoy: Update proxylib interface #14560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrajahalme
added
area/proxy
|
test-me-please |
|
retest-gke |
|
Known flake #13774 on k8s 1.20. |
|
retest-4.9 |
|
Known flake #12511 on netnext |
|
retest-net-next |
jrajahalme
force-pushed
the
pr/jrajahalme/envoy-fix-proxylib
branch
from
68d25f8
to
9be77b4
Compare
|
test-me-please |
The number of bytes requested by a proxylib parser was not reset after the bytes were delivered, which required parsers to request a specific number of bytes after each frame. Existing parsers do this, so they are not affected. In this version the Cilium network filter is changed to reset the number of needed bytes to zero after they are received so that the parser will be called again even if it does not issue an explicit MORE operation. Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
jrajahalme
force-pushed
the
pr/jrajahalme/envoy-fix-proxylib
branch
from
9be77b4
to
98b12cb
Compare
|
test-me-please |
aanm
approved these changes
Jan 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The number of bytes requested by a proxylib parser was not reset after
the bytes were delivered, which required parsers to request a specific
number of bytes after each frame. Existing parsers do this, so they
are not affected.
In this version the Cilium network filter is changed to reset the
number of needed bytes to zero after they are received so that the
parser will be called again even if it does not issue an explicit MORE
operation.
Signed-off-by: Jarno Rajahalme jarno@covalent.io