Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugtool: add taskset #14568

Merged
merged 1 commit into from Jan 12, 2021
Merged

Conversation

youssefazrak
Copy link
Contributor

To assist with additional debugging around processor affinity, we are
adding the Taskset command to the bugtool.

Fixes: #14566

Signed-off-by: Youssef Azrak yazrak.tech@gmail.com

To assist with additional debugging around processor affinity, we are
adding the Taskset command to the bugtool.

Fixes: cilium#14566

Signed-off-by: Youssef Azrak <yazrak.tech@gmail.com>
@youssefazrak youssefazrak requested a review from a team as a code owner January 9, 2021 17:31
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 9, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Jan 9, 2021
@youssefazrak
Copy link
Contributor Author

@joestringer
I added the -pc flag instead of the simple -pc as this gives back a more "user-friendly" result for the cpu affinity instead of the hexadecimal value.

Btw, numactl -H seems to give some useful information at a higher-level as it is aware of the processor topology and how the CPU cores map to CPU sockets.

@twpayne twpayne added the release-note/misc This PR makes changes that have no direct user impact. label Jan 11, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 11, 2021
Copy link
Contributor

@twpayne twpayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@joestringer
Copy link
Member

numactl -H looks kinda interesting, if we were to add it we'd have to also extend the container image to include the tool.

Though that said I'm not sure it necessarily matters so much for general debugging. The reason I proposed taskset is because it observes state that Go uses to detect the number of CPUs and therefore could impact BPF map initialization and so on. Not sure whether the NUMA layout is likely to impact those kinds of things in such a way that it's important to retrospectively analyse rather than an active investigation into e.g. performance, queue configuration, etc.?

@joestringer
Copy link
Member

PR LGTM, doesn't impact CI so merging.

@joestringer joestringer merged commit 84061d1 into cilium:master Jan 12, 2021
@youssefazrak youssefazrak deleted the bugtool_cpu_affinity branch March 19, 2021 00:13
@twpayne
Copy link
Contributor

twpayne commented Mar 19, 2021

Marking this PR for backport, as it's another useful addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Add taskset to bugtool
5 participants